[Limit Orders]: QA Fixes

[crnbarr93]

What is the purpose of the change:

These changes fix the following:

• Table row overlap on order history page
• Missing translations
• Incorrect background on portfolio page
• Buy/Sell/Swap Inputs resizing with font

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend	🛑 Canceled (Inspect)			Aug 8, 2024 11:37am

4 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend-datadog	⬜️ Ignored (Inspect)	Visit Preview		Aug 8, 2024 11:37am
osmosis-frontend-dev	⬜️ Ignored (Inspect)	Visit Preview		Aug 8, 2024 11:37am
osmosis-frontend-edgenet	⬜️ Ignored (Inspect)			Aug 8, 2024 11:37am
osmosis-testnet	⬜️ Ignored (Inspect)	Visit Preview		Aug 8, 2024 11:37am

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The recent updates across multiple components enhance the user experience by refining state management, standardizing rendering logic, and improving localization clarity. Key changes include the simplification of pagination handling in order history, the removal of automatic data refetch intervals in the order book, and updates to translation keys for contextual clarity. These modifications aim to streamline user interactions, ensure consistent layouts, and enhance the overall responsiveness of the application.

Changes

Files	Change Summary
.../complex/orders-history/index.tsx	Simplified count parameter in useWindowVirtualizer; updated rendering logic for robustness; modified key attributes for enhanced React reconciliation; improved translation key for headers.
.../hooks/limit-orders/use-orderbook.ts	Removed refetchInterval property from useOrderbookClaimableOrders, eliminating automatic data refetch every 2 seconds, which impacts data responsiveness.
.../transactions/transaction-content.tsx	Updated translation key for improved contextual clarity from orderHistory.${defaultTab} to transactions.${defaultTab}.
.../complex/asset-fieldset.tsx	Centralized calcFontSize logic; modified <div> class to include a fixed height for improved layout consistency.
.../complex/orders-history/cells/actions.tsx	Added state management to reset claiming and cancelling states on order_id changes; improved error handling for better user experience.
.../complex/portfolio/portfolio-page.tsx	Integrated classNames for responsive styling based on feature flags; improved dynamic rendering logic.
.../table/asset-balances.tsx	Introduced feature flag mechanism for conditional header styling; enhanced rendering based on feature toggles.
.../place-limit-tool/index.tsx	Expanded NON_DISPLAY_ERRORS to include a third error type, improving error handling logic.
.../swap-tool/alt.tsx	Added calcFontSize utility for dynamic font size adjustments based on input; modified style logic for better responsiveness.
.../utils/formatter.ts	Introduced calcFontSize function for responsive font size calculations based on character count and device type.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant OrderHistory
    participant OrderbookHook

    User->>OrderHistory: Load order history
    OrderHistory->>OrderbookHook: Fetch initial orders
    OrderbookHook-->>OrderHistory: Return orders
    OrderHistory-->>User: Display order history

    User->>OrderbookHook: Update order
    OrderbookHook->>OrderbookHook: Check for changes
    OrderbookHook-->>User: Display updated status

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)

packages/web/components/transactions/transaction-content.tsx (1)

99-99: Translation keys missing in translation files

The translation keys transactions.history and transactions.orders are not present in the translation files. Please update the translation files to include these keys to prevent missing translations in the UI.

Analysis chain

Verify the translation key update.

Ensure that the translation files have been updated to reflect the change from orderHistory.${defaultTab} to transactions.${defaultTab}. This will prevent missing translations in the UI.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that the translation files contain the updated keys.

# Test: Search for the updated translation keys. Expect: Occurrences of `transactions.history` and `transactions.orders`.
rg --type json 'transactions\.(history|orders)'

Length of output: 49

---

Script:

#!/bin/bash
# Description: Search for any occurrences of `transactions.` keys in translation files to ensure comprehensive verification.

rg --type json 'transactions\.' -A 2

Length of output: 1545

[coderabbitai]

Actionable comments posted: 1