[Limit Orders]: Post Launch QA

[crnbarr93]

What is the purpose of the change:

These changes are mostly small tweaks for post launch QA:

• Moved price too low/high error to just above price input
• Added more translations
• Added a toggleable minimum order amount for limit orders
• Added a bandaid fix to denom selection modal

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 13, 2024 5:06pm

4 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend-datadog	⬜️ Ignored (Inspect)	Visit Preview		Aug 13, 2024 5:06pm
osmosis-frontend-dev	⬜️ Ignored (Inspect)	Visit Preview		Aug 13, 2024 5:06pm
osmosis-frontend-edgenet	⬜️ Ignored (Inspect)			Aug 13, 2024 5:06pm
osmosis-testnet	⬜️ Ignored (Inspect)	Visit Preview		Aug 13, 2024 5:06pm

[coderabbitai]

Walkthrough

The recent updates across several components significantly enhance functionality and user experience by improving error handling for limit orders, refining conditional rendering logic, and bolstering internationalization support. Key modifications include the introduction of a minimum order value constant, localized messages for better language adaptability, and adjustments to loading indicator behaviors, resulting in a more intuitive and responsive interface.

Changes

Files	Change Summary
.../complex/asset-fieldset.tsx	Minor formatting change by removing a blank line, no impact on functionality.
.../place-limit-tool/index.tsx	Added MIN_ORDER_VALUE import, expanded error handling for limit orders, improved error displays, and modified loading state conditions for better UX.
.../place-limit-tool/limit-price-selector.tsx	Restructured conditional rendering for the GenericDisclaimer to prioritize error messages, enhancing clarity and user experience.
.../trade-tool/index.tsx	Simplified condition for rendering the <Link> component, allowing access to transactions even when no orders exist, improving user interaction.
.../limit-orders/use-place-limit.ts	Introduced MIN_ORDER_VALUE constant for enforcing a minimum order value constraint, modifying error handling logic within usePlaceLimit.
.../modals/review-order.tsx	Enhanced localization by replacing hardcoded strings with translation function calls, improving internationalization support for displayed messages.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PlaceLimitTool
    participant ErrorHandler
    participant LimitOrders

    User->>PlaceLimitTool: Attempts to place limit order
    PlaceLimitTool->>LimitOrders: Validate paymentFiatValue
    LimitOrders-->>PlaceLimitTool: Return error if below MIN_ORDER_VALUE
    PlaceLimitTool->>ErrorHandler: Display appropriate error message
    ErrorHandler->>User: Show localized error message

Loading

sequenceDiagram
    participant User
    participant TradeTool
    participant Transactions

    User->>TradeTool: Access transactions
    TradeTool->>Transactions: Check if wallet is connected
    Transactions-->>User: Display transactions page

Loading

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 72714e9 and fa33303.

Files ignored due to path filters (17)

• packages/web/localizations/de.json is excluded by !**/*.json
• packages/web/localizations/en.json is excluded by !**/*.json
• packages/web/localizations/es.json is excluded by !**/*.json
• packages/web/localizations/fa.json is excluded by !**/*.json
• packages/web/localizations/fr.json is excluded by !**/*.json
• packages/web/localizations/gu.json is excluded by !**/*.json
• packages/web/localizations/hi.json is excluded by !**/*.json
• packages/web/localizations/ja.json is excluded by !**/*.json
• packages/web/localizations/ko.json is excluded by !**/*.json
• packages/web/localizations/pl.json is excluded by !**/*.json
• packages/web/localizations/pt-br.json is excluded by !**/*.json
• packages/web/localizations/ro.json is excluded by !**/*.json
• packages/web/localizations/ru.json is excluded by !**/*.json
• packages/web/localizations/tr.json is excluded by !**/*.json
• packages/web/localizations/zh-cn.json is excluded by !**/*.json
• packages/web/localizations/zh-hk.json is excluded by !**/*.json
• packages/web/localizations/zh-tw.json is excluded by !**/*.json

Files selected for processing (3)

• packages/web/components/place-limit-tool/index.tsx (7 hunks)
• packages/web/components/trade-tool/index.tsx (4 hunks)
• packages/web/modals/review-order.tsx (5 hunks)

Files skipped from review as they are similar to previous changes (3)

• packages/web/components/place-limit-tool/index.tsx
• packages/web/components/trade-tool/index.tsx
• packages/web/modals/review-order.tsx

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1