Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(packages): Clean older registry packages #7847

Closed
wants to merge 1 commit into from

Conversation

heliocastro
Copy link
Contributor

To avoid exceed the limit of package storage for the organization on the defined registry, all packages not tagged as latest or version will be removed to the minimum limit defined.

Default is allow last 3 intermediary packages (snapshots) remains on registry.

@heliocastro heliocastro self-assigned this Nov 12, 2023
@heliocastro heliocastro marked this pull request as ready for review November 12, 2023 12:14
@heliocastro heliocastro requested a review from a team as a code owner November 12, 2023 12:14
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b3063be) 67.16% compared to head (9475384) 67.06%.
Report is 49 commits behind head on main.

❗ Current head 9475384 differs from pull request most recent head ce36c2f. Consider uploading reports for the commit ce36c2f to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7847      +/-   ##
============================================
- Coverage     67.16%   67.06%   -0.11%     
+ Complexity     2049     2041       -8     
============================================
  Files           357      356       -1     
  Lines         17158    17045     -113     
  Branches       2461     2438      -23     
============================================
- Hits          11525    11431      -94     
+ Misses         4611     4594      -17     
+ Partials       1022     1020       -2     
Flag Coverage Δ
funTest-docker 63.11% <ø> (-3.14%) ⬇️
funTest-non-docker 34.95% <ø> (+0.98%) ⬆️
test 36.10% <ø> (-0.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heliocastro heliocastro marked this pull request as draft November 12, 2023 12:28
@heliocastro heliocastro force-pushed the heliocastro/clean_older_packages branch 9 times, most recently from 52be3e9 to 1228905 Compare November 12, 2023 13:10
@heliocastro heliocastro marked this pull request as ready for review November 12, 2023 13:10
Copy link
Member

@tsteenbe tsteenbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heliocastro I would replace wherever you use 'clean' with 'clean up' as you not making these packages clean but you are making things tidy.

.github/actions/clean_packages/action.yml Outdated Show resolved Hide resolved
.github/actions/clean_packages/clean_packages.py Outdated Show resolved Hide resolved
.github/actions/clean_packages/clean_packages.py Outdated Show resolved Hide resolved
.github/workflows/clean_packages.yml Outdated Show resolved Hide resolved
.github/workflows/clean_packages.yml Outdated Show resolved Hide resolved
.github/workflows/clean_packages.yml Outdated Show resolved Hide resolved
.github/actions/clean_packages/clean_packages.py Outdated Show resolved Hide resolved
.github/actions/clean_packages/clean_packages.py Outdated Show resolved Hide resolved
.github/workflows/clean_packages.yml Outdated Show resolved Hide resolved
.github/workflows/clean_up_package_registry.yml Outdated Show resolved Hide resolved
.github/workflows/clean_up_package_registry.yml Outdated Show resolved Hide resolved
.github/actions/clean_up_package_registry/action.yml Outdated Show resolved Hide resolved
.github/actions/clean_up_package_registry/action.yml Outdated Show resolved Hide resolved
@heliocastro heliocastro force-pushed the heliocastro/clean_older_packages branch from 86a16d9 to e4171b2 Compare November 13, 2023 08:45
@heliocastro heliocastro force-pushed the heliocastro/clean_older_packages branch 4 times, most recently from 9d2615f to 9475384 Compare November 14, 2023 17:20
@heliocastro heliocastro force-pushed the heliocastro/clean_older_packages branch 2 times, most recently from 9598c0a to bc95ff7 Compare February 8, 2024 17:09
To avoid exceed the limit of package storage for the organization on
the defined registry, all packages not tagged as latest or version will
be removed to the minimum limit defined.

Default is allow last 3 intermediary packages (snapshots) remains on
registry.

Signed-off-by: Helio Chissini de Castro <[email protected]>
@heliocastro heliocastro force-pushed the heliocastro/clean_older_packages branch from bc95ff7 to ce36c2f Compare February 8, 2024 17:14
@heliocastro heliocastro closed this Feb 8, 2024
@heliocastro heliocastro deleted the heliocastro/clean_older_packages branch February 8, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants