-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jerryp/gallery v2 #665
Open
jerry-peng
wants to merge
173
commits into
develop
Choose a base branch
from
jerryp/gallery_v2
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Jerryp/gallery v2 #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix water quality graphing code (specifically data filtering)
Fixes Server 500 when school is deleted
removed educator kits and upload resource
Edge pages now display gallery and datasheets, drop downs work
Changed code to calculate sample averages
Fixed side scrolling issues on site details (affects laptops as well)
…nents of this app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #485 637
Browser support for gallery video player:
Chrome: does not preload (good), cannot move video seek bar (bad)
Firefox: works fine, does not preload (good), seek bar works (good)
Safari (Mac): not working
Safari (Phone): not working
Edge: does not preload (good), moving seek bar requires downloading video before seeking position (bad)
Changes in this PR.
Testing this PR.
Expected Output.
@osuosl/devs