Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jerryp/gallery v2 #665

Open
wants to merge 173 commits into
base: develop
Choose a base branch
from
Open

Jerryp/gallery v2 #665

wants to merge 173 commits into from

Conversation

jerry-peng
Copy link
Contributor

@jerry-peng jerry-peng commented Jun 27, 2018

fixes issue #485 637

Browser support for gallery video player:
Chrome: does not preload (good), cannot move video seek bar (bad)
Firefox: works fine, does not preload (good), seek bar works (good)
Safari (Mac): not working
Safari (Phone): not working
Edge: does not preload (good), moving seek bar requires downloading video before seeking position (bad)

Changes in this PR.

  • Added templates for adding/viewing/deleting gallery videos and field journals.
  • Added data for field journals and gallery videos.
  • Make video fast for streaming. (Able to play before downloading entire file)

Testing this PR.

  1. Create an editor and a contributor account. Approve them through admin account
  2. Login as contributor. View some existing videos/field journal. Make sure the website displays correctly.
  3. try clicking the delete video/ delete journal buttons. It should not work.
  4. Try adding new video/journal. For journal, make sure title, entry, date_time fields are required. For videos, make sure title, date_time, video fields are required, and thumbnail and description fields are optional.
  5. After adding the videos/journal, the webpage should redirect to the site page. Make sure the newly added videos/journals appear on the site page.
  6. Logout, and login as contributor. Do the same (step 2-5) The only difference is, after deleting videos/field journals, they are deleted and user is directed back to the site page. Make sure deleted videos/journals do not appear on the site page.

Expected Output.

  1. Everything that has "make sure" is made sure.
$ make test
[... test output ...]

@osuosl/devs

Tan and others added 30 commits January 3, 2018 15:27
jerry-peng and others added 22 commits March 7, 2018 14:56
Fix water quality graphing code (specifically data filtering)
Fixes Server 500 when school is deleted
removed educator kits and upload resource
Edge pages now display gallery and datasheets, drop downs work
Changed code to calculate sample averages
Fixed side scrolling issues on site details (affects laptops as well)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants