Issue #32: Add support for reading markings from MusicXML #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use same methods for reading scores in all tests where possible. Do not unnecessarily validate scores that can be expected to be valid.
Change tie beginning container to have a more generic name so that it can sensibly be used for other connections between notes.
Add support for reading markings that span multiple notes within the same voice in the same part.
Trying to read articulations from other types of nodes is unnecessary and leads to logging warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for reading markings (slurs, glissando) from MusicXML.
The implementation only supports markings that occur between notes in the same voice.
Handling of slurs that cross parts and voices is more complex and is to be handled in issue #109