Add TS Def file #2
Conversation
| script?: string; | ||
| minSpreadWidth?: number; | ||
| gap?: number; | ||
| onPress?(ev: object): void; |
There was a problem hiding this comment.
onPress must receive other props and not a event object. See the file: https://github.com/ottofeller/epubjs-rn/blob/master/src/Rendition.js#L346
case "press": {
this.props.onPress && this.props.onPress(decoded.cfi, decoded.position, this);
break;
}The correct props to ts definition file must be:
onPress?(cfi: string, position {x: number; y: number;}, rendition: Rendition): void;But, now, we have a potential problem: in this definition, we not have a exported Rendition (as interface or as Component).
There was a problem hiding this comment.
And, complementing, the Epub component onPress event is parsed directly to the Rendition component, then, to see better the props of the Epub, is needed to see the behaviour of the Rendition.
There was a problem hiding this comment.
The same occur to other events in those TypeScript definitions.
| onLocationsReady?(): void; | ||
| onViewAdded?(): void; | ||
| beforeViewRemoved?(): void; | ||
| width: number; |
There was a problem hiding this comment.
The width (and the height properties is not required by the Epub component).
| declare module '@ottofeller/epubjs-rn' { | ||
| import React from 'react'; | ||
|
|
||
| interface Props { |
There was a problem hiding this comment.
The onError event is not defined in the props.
| import React from 'react'; | ||
|
|
||
| interface Props { | ||
| style?: object; |
There was a problem hiding this comment.
This is style is the react-native style? If positive, consider that changing this from object to real style definition, like StyleProp<ViewStyle> for the View component.
No description provided.