AO3-4250 Made gift recipients update on blurbs on pseud / username changes #1742
melinathreviewdog.yml
on: pull_request
Rubocop
1m 3s
ERB Lint runner
1m 35s
Annotations
1 error and 5 warnings
|
Rubocop
Process completed with exit code 1.
|
|
Rubocop:
app/models/pseud.rb#L79
[rubocop] reported by reviewdog 🐶
`after_destroy` is supposed to appear before `after_commit`.
Raw Output:
app/models/pseud.rb:79:3: C: Rails/ActiveRecordCallbacksOrder: `after_destroy` is supposed to appear before `after_commit`.
|
|
Rubocop:
app/models/pseud.rb#L394
[rubocop] reported by reviewdog 🐶
Add empty line after guard clause.
Raw Output:
app/models/pseud.rb:394:5: C: Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
|
|
Rubocop:
app/models/pseud.rb#L394
[rubocop] reported by reviewdog 🐶
Prefer `!user.nil?` over `user != nil`.
Raw Output:
app/models/pseud.rb:394:59: C: Style/NonNilCheck: Prefer `!user.nil?` over `user != nil`.
|
|
Rubocop:
app/models/pseud.rb#L394
[rubocop] reported by reviewdog 🐶
Prefer `!user.default_pseud.nil?` over `user.default_pseud != nil`.
Raw Output:
app/models/pseud.rb:394:74: C: Style/NonNilCheck: Prefer `!user.default_pseud.nil?` over `user.default_pseud != nil`.
|
|
Rubocop:
app/models/pseud.rb#L395
[rubocop] reported by reviewdog 🐶
Favor the ternary operator (`?:`) or multi-line constructs over single-line `if/then/else/end` constructs.
Raw Output:
app/models/pseud.rb:395:13: C: Style/OneLineConditional: Favor the ternary operator (`?:`) or multi-line constructs over single-line `if/then/else/end` constructs.
|