-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AO3-6667 Languages page performance improvements #4714
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just took a quick look and it's possible the failing tests need work_search: true
to set up the indexes, like
context "where the user is a maintainer", work_search: true, bookmark_search: true do |
config/locales/views/en.yml
Outdated
add: Add a language | ||
description: Work Languages | ||
edit: Edit | ||
suggest: Suggest a language |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you keep the original capitalization from the navigation actions? Our navigation should always be title case. (You can, however, drop the "a" if you want.) It also wouldn't hurt to group them under navigation
like we do elsewhere to give Translation a bit more context, e.g.
otwarchive/config/locales/views/en.yml
Lines 356 to 361 in 653c19c
navigation: | |
approved: Approved | |
rejected_by_collection: Rejected by Collection | |
rejected_by_user: Rejected by User | |
unreviewed_by_collection: Awaiting Collection Approval | |
unreviewed_by_user: Awaiting User Approval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! I think keeping the a
sounds better but I can remove it if that's the standard
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing
)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6667
Purpose