Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6570 Import Work error message overflows for long URLs #4716

Merged

Conversation

smclairecarden
Copy link
Contributor

Issue

https://otwarchive.atlassian.net/browse/AO3-6570

Purpose

Set word-wrap to break-word on the error element so that the text wraps properly and does not overflow.

Testing Instructions

How can the Archive's QA team verify that this is working as you intended?

Log in.
Head to Import Work and enter a long external URL
Import it more than once and make sure the element doesn't spill out of the box - make your browser window small.

If you have a Jira account with access, please update or comment on the issue
with any new or missing testing instructions instead.

References

Are there other relevant issues/pull requests/mailing list discussions?

Credit

What name and pronouns should we use to credit you in the Archive of Our Own's Release Notes?

Claire C
Screen Shot 2024-01-12 at 8 30 38 PM

If you have a Jira account, please include the same name in the "Full name"
field on your Jira profile, so we can assign you the issues you're working on.

Please note that if you do not fill in this section, we will use your GitHub account name and
they/them pronouns.

@smclairecarden smclairecarden changed the title Import Work error message overflows for long URLs AO3-6570 - Import Work error message overflows for long URLs Jan 13, 2024
Copy link
Collaborator

@sarken sarken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small question/suggestion! If there's a reason it won't work, this is fine as-is.

@brianjaustin brianjaustin changed the title AO3-6570 - Import Work error message overflows for long URLs AO3-6570 Import Work error message overflows for long URLs Jan 17, 2024
@brianjaustin brianjaustin merged commit 812d966 into otwcode:master May 17, 2024
26 checks passed
sarken added a commit that referenced this pull request May 31, 2024
sarken added a commit that referenced this pull request May 31, 2024
…4818)

Revert "AO3-6570 Import Work error message overflows for long URLs (#4716)"

This reverts commit 812d966.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants