Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make DAO list linkable in user profile #484

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

0xMillz
Copy link
Contributor

@0xMillz 0xMillz commented Oct 17, 2024

Description

Adds individual links for each DAO on the user profile page "DAOs" list. Previously it was a somewhat-confusing list of text strings. This feature ideally improves user experience and helps users discover new DAOs when viewing other users' profiles pages.

Screenshot 2024-10-16 at 11 53 54 PM

Motivation & context

Previously it was a somewhat-confusing list of text strings. This feature ideally improves user experience and helps users discover new DAOs when viewing other users' profiles pages.

Code review

I also removed a prop that had the name key from the DaoFeedCardSkeleton component. key is a reserved word in React and cannot be used as a prop name. It also served no function as the parent component is already uniquely identified by the same key.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have done a self-review of my own code
  • Any new and existing tests pass locally with my changes
  • My changes generate no new warnings (lint warnings, console warnings, etc)

Copy link

vercel bot commented Oct 17, 2024

@0xMillz is attempting to deploy a commit to the Nouns Builder Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nouns-builder ✅ Ready (Inspect) Visit Preview Oct 17, 2024 7:23am
testnet-nouns-builder ✅ Ready (Inspect) Visit Preview Oct 17, 2024 7:23am

@neokry neokry merged commit 6413968 into ourzora:main Oct 18, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants