Added multiple flags to moodle #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 11, 2024 18:43
Nicceboy
requested changes
Oct 16, 2024
Nicceboy
approved these changes
Oct 28, 2024
Comment on lines
+179
to
+228
| for answer in answers { | ||
| match answer.fraction { | ||
| 33 => { | ||
| assert!( | ||
| answer.text.contains("task4_prefix:") | ||
| || answer.text.contains("task5_prefix:") | ||
| || answer.text.contains("task6_prefix:") | ||
| ); | ||
| } | ||
| 67 => { | ||
| assert!( | ||
| (answer.text.contains("task4_prefix:") | ||
| && answer.text.contains("task5_prefix:")) | ||
| || (answer.text.contains("task6_prefix:") | ||
| && answer.text.contains("task5_prefix:")) | ||
| || (answer.text.contains("task6_prefix:") | ||
| && answer.text.contains("task4_prefix:")) | ||
| ); | ||
| } | ||
| 100 => { | ||
| assert!( | ||
| (answer.text.contains("task4_prefix:") | ||
| && answer.text.contains("task5_prefix:") | ||
| && answer.text.contains("task6_prefix:")) | ||
| ); | ||
| } | ||
| _ => { | ||
| unreachable!("Unexpected fraction value encountered in test") | ||
| } | ||
| } | ||
| } | ||
| for answer in answers2 { | ||
| assert!(answer.fraction == 100); | ||
| assert!(answer.text.contains("task1:")); | ||
| } | ||
| for answer in answers3 { | ||
| match answer.fraction { | ||
| 50 => { | ||
| assert!(answer.text.contains("task2:") || answer.text.contains("task3:")); | ||
| } | ||
| 100 => { | ||
| assert!(answer.text.contains("task2:") && answer.text.contains("task3:")); | ||
| } | ||
| _ => { | ||
| unreachable!("Unexpected fraction value encountered in test") | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
OK. This does not ensure that there are no duplicates but maybe we can trust the logic of itertools. However, tests should always ensure that if we made changes in the code, the end functionality remains and we get confidence that system still works, so tests should be strict enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17
-Added multiple flag support for answers and a test that shows functionality (test_multiple_flags)
Current separator for flags: ";"
Using itertools crate to implement combinations and permutations for flags
Generating answers for 3 flags currently adds total 6+12+12 = 30 answers