Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): bun create with github repo and finding package.json #10190

Merged
merged 2 commits into from
Apr 13, 2024

Conversation

dylan-conway
Copy link
Member

What does this PR do?

Removes unreachable from reachable errors.

Fixes bug finding package.json from bun create template.

fixes #10183

How did you verify your code works?

manually and added a test

Copy link
Contributor

github-actions bot commented Apr 12, 2024

Copy link
Contributor

github-actions bot commented Apr 12, 2024

Copy link
Contributor

github-actions bot commented Apr 12, 2024

@Jarred-Sumner 1 files with test failures on bun-darwin-aarch64:

View test output

#bc2f3a8888c5358461229557205cb673a35b5b60

@Jarred-Sumner Jarred-Sumner merged commit 176af5c into main Apr 13, 2024
27 of 32 checks passed
@Jarred-Sumner Jarred-Sumner deleted the dylan/fix-10183 branch April 13, 2024 02:02
cirospaciari pushed a commit that referenced this pull request Apr 14, 2024
Co-authored-by: Jarred Sumner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WINDOWS] bun create https://github.com/.... crash: 'reached unreachable code'
2 participants