Add documentation for threadsafe option in FFI JSCallback #15982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonIsaac
approved these changes
Dec 27, 2024
190n
requested changes
Jan 6, 2025
…update FOOBAR and I dont know why!!!
190n
approved these changes
Jan 6, 2025
auto-merge was automatically disabled
January 7, 2025 10:53
Head branch was pushed to by a user without write access
citkane
force-pushed
the
ffi_doc_update
branch
from
fe1b201 to
253c3ec
Compare
|
Sorry @citkane, I don't know why this didn't merge. I'll try running CI again. I don't think you need to be updating this against |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
It was my initial bad for not updating my fork before committing the change. I see that all the checks and approvals have now passed, but still no merge. I will leave it to you to push the right buttons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It documents the
threadsafeoption for FFIJSCallback.It resolves #15925
How did you verify your code works?