-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve stack overflow, show more properties in Error objects #15985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated 11:07 PM PT - Dec 25th, 2024
✅ @paperdave, your commit 1cf8c16 has passed in 🧪 try this PR locally: bunx bun-pr 15985 |
Jarred-Sumner
force-pushed
the
jarred/stack-overflow
branch
from
December 25, 2024 00:35
72a765c
to
2c81d8c
Compare
Great! I want to report it soon but u already open this)) This happened with my I add additional keys such as But it shows only in Node for now( |
probably-neb
pushed a commit
to probably-neb/bun
that referenced
this pull request
Jan 7, 2025
…h#15985) Co-authored-by: Dave Caruso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I got sidetracked while trying to make the postgres client throw better errors
Fixes #817
Fixes #185
In order to be able to display all the own properties of Error objects when you console.log them, we need to handle stack overflow
In order to handle stack overflow, we need a way to track stack overflow
Now that we have a way to know in Zig if there's a stack overflow, I added it to the JS parser so we can handle stack overflow while visiting
Also, we should not be using
std.bit_set
. It copies the entire 90 KB bitset onto the stack. Our bun.bit_set fixes that.How did you verify your code works?
There are some tests.