Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3Client): add support for ListObjectsV2 action #16948

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Inqnuam
Copy link
Contributor

@Inqnuam Inqnuam commented Jan 31, 2025

What does this PR do?

This PR adds support for S3 ListObjectsV2 action.
Same input/output as @aws-sdk/s3-client.

Closes #16495
May be helpful for #8947

  • Documentation or TypeScript types
  • Code changes

How did you verify your code works?

I wrote automated tests

  • I included a test for the new code, or existing tests cover it
  • I ran my tests locally and they pass (bun-debug test test/js/bun/s3/s3-list-objects.test.ts)
  • I ran my tests on AWS and they pass

If Zig files changed:

  • I checked the lifetime of memory allocated to verify it's (1) freed and (2) only freed when it should be
  • I included a test for the new code, or an existing test covers it
  • JSValue used outside outside of the stack is either wrapped in a JSC.Strong or is JSValueProtect'ed
  • I wrote TypeScript/JavaScript tests and they pass locally (bun-debug test test/js/bun/s3/s3-list-objects.test.ts)

If new methods, getters, or setters were added to a publicly exposed class:

  • I added TypeScript types for the new methods, getters, or setters

@zshzebra
Copy link

zshzebra commented Feb 2, 2025

Hopefully a maintainer can get to this soon. I would love to see this added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

s3 list function
2 participants