hmr fixes #17239

paperclover · 2025-02-10T19:05:38Z

opening this now so tests can run and we can identify what is flaky, if any.

Fixes dev server doesnt support node polyfills #17196 node polyfills
- TODO investigate cant find variable global
Fixes false assertion when tracing files looking for errors. Files with errors are stale, I'm surprised I did not hit this assertion during development. dev server: assertion fail when tracing html route during generateHTMLPayload #17183 (comment). The original issue here is another bug though.
Change css check to !js, Fixes Uncaught rejection at start in HMR due to HTML assets being imported in JS #17204
Fix incorrect initial filename for js files being all zeros

robobun · 2025-02-10T19:05:49Z

^{Updated 1:20 AM PT - Feb 11th, 2025}

❌ @Jarred-Sumner, your commit fa934f8 has 11 failures in Build #11435:

test/cli/install/bun-install-registry.test.ts - 2 failing on 🪟 2019 x64-baseline
test/cli/install/bun-install-registry.test.ts - 2 failing on 🪟 2019 x64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🪟 2019 x64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🪟 2019 x64-baseline
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 24.04 aarch64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 22.04 aarch64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 12 aarch64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 20.04 aarch64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 3.20 aarch64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🍎 14 aarch64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 22.04 x64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 24.04 x64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 20.04 x64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 12 x64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 20.04 x64-baseline
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 24.04 x64-baseline
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 12 x64-baseline
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 22.04 x64-baseline
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🍎 13 aarch64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 3.20 x64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🐧 3.20 x64-baseline
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🍎 14 x64
test/js/bun/css/doesnt_crash.test.ts - 12 failing on 🍎 13 x64
test/cli/install/bun-link.test.ts - index out of bounds: index 50, len 49",%0a+ "oh no: bun has crashed. this indicates a bug in bun, not your code.",%0a+ "",%0a+ "to send a redacted crash report to bun's team,",%0a+ "please file a github issue using the link below:",%0a+ "",%0a+ " https://bun.report/1.2.3/el2fa934f8aggggwbk2k8cq/k4es8w0fwhss5i4819odcykernel32.dllos9fcsntdll.dllis0wa0enrlzetjrvdily1rye9tsmovzusptllibauagugo5ktmkzhyagd69qxa",%0a+ "",%0a ""%0a ]%0a%0a- expected - 0%0a+ received + 17%0a%0a at (c:\buildkite-agent\builds\ec2amaz-7mcumae\bun\bun\test\cli\install\bun-link.test.ts:78:30) on 🪟 2019 x64-baseline
test/cli/install/bun-link.test.ts - index out of bounds: index 50, len 49",%0a+ "oh no: bun has crashed. this indicates a bug in bun, not your code.",%0a+ "",%0a+ "to send a redacted crash report to bun's team,",%0a+ "please file a github issue using the link below:",%0a+ "",%0a+ " https://bun.report/1.2.3/wl2fa934f8aggggwbqjx9c8z/8eq+15f4+s45i4lz3pdcykernel32.dllos9fcsntdll.dllis0wa0enrlzetjrvdily1rye9tsmovzusptllibauagugo5ktmkzhyagd69qxa",%0a+ "",%0a ""%0a ]%0a%0a- expected - 0%0a+ received + 17%0a%0a at (c:\buildkite-agent\builds\ec2amaz-7mcumae\bun\bun\test\cli\install\bun-link.test.ts:78:30) on 🪟 2019 x64
test/cli/install/bun-install-patch.test.ts - internal assertion failure on 🪟 2019 x64
test/bake/dev/html.test.ts - 1 failing on 🪟 2019 x64
test/bake/dev/html.test.ts - 1 failing on 🪟 2019 x64-baseline
test/bake/dev/html.test.ts - 1 failing on 🍎 14 aarch64
test/bake/dev/html.test.ts - 1 failing on 🍎 13 aarch64
test/bake/dev/html.test.ts - 1 failing on 🐧 24.04 aarch64
test/bake/dev/html.test.ts - 1 failing on 🐧 12 aarch64
test/bake/dev/html.test.ts - 1 failing on 🐧 22.04 aarch64
test/bake/dev/html.test.ts - 1 failing on 🐧 20.04 aarch64
test/bake/dev/html.test.ts - 1 failing on 🐧 3.20 aarch64
test/bake/dev/html.test.ts - 1 failing on 🍎 14 x64
test/bake/dev/html.test.ts - 1 failing on 🍎 13 x64
test/bake/dev/html.test.ts - 1 failing on 🐧 22.04 x64
test/bake/dev/html.test.ts - 1 failing on 🐧 20.04 x64
test/bake/dev/html.test.ts - 1 failing on 🐧 24.04 x64
test/bake/dev/html.test.ts - 1 failing on 🐧 22.04 x64-baseline
test/bake/dev/html.test.ts - 1 failing on 🐧 12 x64
test/bake/dev/html.test.ts - 1 failing on 🐧 20.04 x64-baseline
test/bake/dev/html.test.ts - 1 failing on 🐧 12 x64-baseline
test/bake/dev/html.test.ts - 1 failing on 🐧 24.04 x64-baseline
test/bake/dev/html.test.ts - 1 failing on 🐧 3.20 x64-baseline
test/bake/dev/html.test.ts - 1 failing on 🐧 3.20 x64
test/bake/dev/ecosystem.test.ts - 1 failing on 🪟 2019 x64
test/bake/dev/ecosystem.test.ts - 1 failing on 🪟 2019 x64-baseline
test/bake/dev/ecosystem.test.ts - 1 failing on 🍎 14 aarch64
test/bake/dev/ecosystem.test.ts - 1 failing on 🍎 13 aarch64
test/bake/dev/ecosystem.test.ts - 1 failing on 🐧 22.04 aarch64
test/bake/dev/ecosystem.test.ts - 1 failing on 🐧 20.04 aarch64
test/bake/dev/ecosystem.test.ts - 1 failing on 🐧 12 aarch64
test/bake/dev/ecosystem.test.ts - 1 failing on 🐧 24.04 aarch64
test/bake/dev/ecosystem.test.ts - 1 failing on 🐧 3.20 aarch64
test/bake/dev/ecosystem.test.ts - 1 failing on 🍎 14 x64
test/bake/dev/ecosystem.test.ts - 1 failing on 🍎 13 x64
test/bake/dev/ecosystem.test.ts - 1 failing on 🐧 12 x64
test/bake/dev/ecosystem.test.ts - 1 failing on 🐧 22.04 x64
test/bake/dev/ecosystem.test.ts - 1 failing on 🐧 22.04 x64-baseline
test/bake/dev/ecosystem.test.ts - 1 failing on 🐧 20.04 x64
test/bake/dev/ecosystem.test.ts - 1 failing on 🐧 20.04 x64-baseline
test/bake/dev/ecosystem.test.ts - 1 failing on 🐧 24.04 x64
test/bake/dev/ecosystem.test.ts - 1 failing on 🐧 24.04 x64-baseline
test/bake/dev/ecosystem.test.ts - 1 failing on 🐧 12 x64-baseline
test/bake/dev/ecosystem.test.ts - 1 failing on 🐧 3.20 x64-baseline
test/bake/dev/ecosystem.test.ts - 1 failing on 🐧 3.20 x64
test/cli/create/create-jsx.test.ts - 2 failing on 🪟 2019 x64
test/cli/create/create-jsx.test.ts - 2 failing on 🪟 2019 x64-baseline
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 20.04 aarch64
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 12 aarch64
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 24.04 aarch64
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 22.04 aarch64
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 3.20 aarch64
test/cli/create/create-jsx.test.ts - 2 failing on 🍎 14 aarch64
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 22.04 x64
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 12 x64
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 24.04 x64
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 20.04 x64
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 24.04 x64-baseline
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 22.04 x64-baseline
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 12 x64-baseline
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 20.04 x64-baseline
test/cli/create/create-jsx.test.ts - 2 failing on 🍎 13 aarch64
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 3.20 x64-baseline
test/cli/create/create-jsx.test.ts - 2 failing on 🐧 3.20 x64
test/cli/create/create-jsx.test.ts - 2 failing on 🍎 14 x64
test/cli/create/create-jsx.test.ts - timeout on 🍎 13 x64
test/bundler/bundler_browser.test.ts - 1 failing on 🍎 14 aarch64
test/bundler/bundler_browser.test.ts - 1 failing on 🍎 13 aarch64
test/bundler/bundler_browser.test.ts - 1 failing on 🐧 24.04 aarch64
test/bundler/bundler_browser.test.ts - 1 failing on 🐧 20.04 aarch64
test/bundler/bundler_browser.test.ts - 1 failing on 🐧 12 aarch64
test/bundler/bundler_browser.test.ts - 1 failing on 🐧 22.04 aarch64
test/bundler/bundler_browser.test.ts - 1 failing on 🐧 3.20 aarch64
test/bundler/bundler_browser.test.ts - 1 failing on 🍎 14 x64
test/bundler/bundler_browser.test.ts - 1 failing on 🍎 13 x64
test/bundler/bundler_browser.test.ts - 1 failing on 🐧 22.04 x64
test/bundler/bundler_browser.test.ts - 1 failing on 🐧 24.04 x64
test/bundler/bundler_browser.test.ts - 1 failing on 🐧 20.04 x64
test/bundler/bundler_browser.test.ts - 1 failing on 🐧 12 x64
test/bundler/bundler_browser.test.ts - 1 failing on 🐧 12 x64-baseline
test/bundler/bundler_browser.test.ts - 1 failing on 🐧 22.04 x64-baseline
test/bundler/bundler_browser.test.ts - 1 failing on 🐧 20.04 x64-baseline
test/bundler/bundler_browser.test.ts - 1 failing on 🐧 24.04 x64-baseline
test/bundler/bundler_browser.test.ts - 1 failing on 🐧 3.20 x64-baseline
test/bundler/bundler_browser.test.ts - 1 failing on 🐧 3.20 x64
test/bake/dev/esm.test.ts - 1 failing on 🍎 14 aarch64
test/bake/dev/esm.test.ts - 1 failing on 🪟 2019 x64-baseline
test/bake/dev/esm.test.ts - 1 failing on 🪟 2019 x64
test/bake/dev/esm.test.ts - 1 failing on 🍎 13 aarch64
test/bake/dev/esm.test.ts - 1 failing on 🐧 20.04 aarch64
test/bake/dev/esm.test.ts - 1 failing on 🐧 24.04 aarch64
test/bake/dev/esm.test.ts - 1 failing on 🐧 22.04 aarch64
test/bake/dev/esm.test.ts - 1 failing on 🐧 12 aarch64
test/bake/dev/esm.test.ts - 1 failing on 🐧 3.20 aarch64
test/bake/dev/esm.test.ts - 1 failing on 🍎 14 x64
test/bake/dev/esm.test.ts - 1 failing on 🍎 13 x64
test/bake/dev/esm.test.ts - 1 failing on 🐧 24.04 x64
test/bake/dev/esm.test.ts - 1 failing on 🐧 20.04 x64
test/bake/dev/esm.test.ts - 1 failing on 🐧 22.04 x64
test/bake/dev/esm.test.ts - 1 failing on 🐧 12 x64
test/bake/dev/esm.test.ts - 1 failing on 🐧 24.04 x64-baseline
test/bake/dev/esm.test.ts - 1 failing on 🐧 22.04 x64-baseline
test/bake/dev/esm.test.ts - 1 failing on 🐧 12 x64-baseline
test/bake/dev/esm.test.ts - 1 failing on 🐧 20.04 x64-baseline
test/bake/dev/esm.test.ts - 1 failing on 🐧 3.20 x64-baseline
test/bake/dev/esm.test.ts - 1 failing on 🐧 3.20 x64
test/bake/dev/dev-plugins.test.ts - 1 failing on 🍎 14 aarch64
test/bake/dev/dev-plugins.test.ts - 1 failing on 🪟 2019 x64
test/bake/dev/dev-plugins.test.ts - 1 failing on 🪟 2019 x64-baseline
test/bake/dev/dev-plugins.test.ts - 1 failing on 🍎 13 aarch64
test/bake/dev/dev-plugins.test.ts - 1 failing on 🐧 20.04 aarch64
test/bake/dev/dev-plugins.test.ts - 1 failing on 🐧 22.04 aarch64
test/bake/dev/dev-plugins.test.ts - 1 failing on 🐧 24.04 aarch64
test/bake/dev/dev-plugins.test.ts - 1 failing on 🐧 12 aarch64
test/bake/dev/dev-plugins.test.ts - 1 failing on 🐧 3.20 aarch64
test/bake/dev/dev-plugins.test.ts - 1 failing on 🍎 14 x64
test/bake/dev/dev-plugins.test.ts - 1 failing on 🍎 13 x64
test/bake/dev/dev-plugins.test.ts - 1 failing on 🐧 22.04 x64
test/bake/dev/dev-plugins.test.ts - 1 failing on 🐧 12 x64
test/bake/dev/dev-plugins.test.ts - 1 failing on 🐧 20.04 x64
test/bake/dev/dev-plugins.test.ts - 1 failing on 🐧 24.04 x64
test/bake/dev/dev-plugins.test.ts - 1 failing on 🐧 20.04 x64-baseline
test/bake/dev/dev-plugins.test.ts - 1 failing on 🐧 22.04 x64-baseline
test/bake/dev/dev-plugins.test.ts - 1 failing on 🐧 24.04 x64-baseline
test/bake/dev/dev-plugins.test.ts - 1 failing on 🐧 12 x64-baseline
test/bake/dev/dev-plugins.test.ts - 1 failing on 🐧 3.20 x64-baseline
test/bake/dev/dev-plugins.test.ts - 1 failing on 🐧 3.20 x64
test/bake/dev/bundle.test.ts - 1 failing on 🍎 14 aarch64
test/bake/dev/bundle.test.ts - 1 failing on 🪟 2019 x64
test/bake/dev/bundle.test.ts - 1 failing on 🪟 2019 x64-baseline
test/bake/dev/bundle.test.ts - 1 failing on 🍎 13 aarch64
test/bake/dev/bundle.test.ts - 1 failing on 🐧 20.04 aarch64
test/bake/dev/bundle.test.ts - 1 failing on 🐧 24.04 aarch64
test/bake/dev/bundle.test.ts - 1 failing on 🐧 22.04 aarch64
test/bake/dev/bundle.test.ts - 1 failing on 🐧 12 aarch64
test/bake/dev/bundle.test.ts - 1 failing on 🐧 3.20 aarch64
test/bake/dev/bundle.test.ts - 1 failing on 🍎 14 x64
test/bake/dev/bundle.test.ts - 1 failing on 🍎 13 x64
test/bake/dev/bundle.test.ts - 1 failing on 🐧 20.04 x64
test/bake/dev/bundle.test.ts - 1 failing on 🐧 24.04 x64
test/bake/dev/bundle.test.ts - 1 failing on 🐧 22.04 x64
test/bake/dev/bundle.test.ts - 1 failing on 🐧 12 x64
test/bake/dev/bundle.test.ts - 1 failing on 🐧 12 x64-baseline
test/bake/dev/bundle.test.ts - 1 failing on 🐧 22.04 x64-baseline
test/bake/dev/bundle.test.ts - 1 failing on 🐧 20.04 x64-baseline
test/bake/dev/bundle.test.ts - 1 failing on 🐧 24.04 x64-baseline
test/bake/dev/bundle.test.ts - 1 failing on 🐧 3.20 x64-baseline
test/bake/dev/bundle.test.ts - 1 failing on 🐧 3.20 x64

🧪 try this PR locally:

bunx bun-pr 17239

revive dev server tests. we need to be running these

989af93

dylan-conway and others added 5 commits February 10, 2025 18:37

window

b73d074

a

b523a3c

always show the memory

ff259c9

Create path-relative.mjs

8a47b78

Fix 1 test

fa934f8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

hmr fixes #17239

hmr fixes #17239

paperclover commented Feb 10, 2025 •

edited

Loading

robobun commented Feb 10, 2025 •

edited

Loading

hmr fixes #17239

Are you sure you want to change the base?

hmr fixes #17239

Conversation

paperclover commented Feb 10, 2025 • edited Loading

robobun commented Feb 10, 2025 • edited Loading

paperclover commented Feb 10, 2025 •

edited

Loading

robobun commented Feb 10, 2025 •

edited

Loading