Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql) fix support for binary numeric values #17245

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Conversation

cirospaciari
Copy link
Member

@cirospaciari cirospaciari commented Feb 11, 2025

What does this PR do?

Fix: #17194
For safety numeric values are always returned as strings (matching postgres.js behavior)

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Tests

@robobun
Copy link

robobun commented Feb 11, 2025

Updated 6:32 PM PT - Feb 10th, 2025

@cirospaciari, your commit 51ce0a1 has 6 failures in Build #11404:


🧪   try this PR locally:

bunx bun-pr 17245

@Jarred-Sumner Jarred-Sumner merged commit 3a231a6 into main Feb 11, 2025
54 of 69 checks passed
@Jarred-Sumner Jarred-Sumner deleted the ciro/fix-numeric branch February 11, 2025 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres SQL numeric columns from select returning, encoding not working
3 participants