fix mockRejectedValue throwing error if not fulfilled on next tick #17258
+55
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This lets
mockRejectedValue()
andmockRejectedValueOnce()
not throw errors if they're not fulfilled / resolved immediately after being set. This would match jest's implementationTo do this I switched up the logic so rather than returning a rejected promise, it returns a function that returns a rejected promise
Fixes #10437
I'm not that familiar with c++ or this codebase, so if theres a cleaner way to implement this please let me know! Thanks
How did you verify your code works?
I wrote automated tests to ensure mocks that weren't called and fullfilled would not throw errors