Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not drop empty arguments in Bun.spawn #17269

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

pjeweb
Copy link

@pjeweb pjeweb commented Feb 12, 2025

What does this PR do?

This will not drop empty string arguments passed to Bun.spawn().

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

  • I checked the lifetime of memory allocated to verify it's (1) freed and (2) only freed when it should be
  • I included a test for the new code, or an existing test covers it
  • JSValue used outside outside of the stack is either wrapped in a JSC.Strong or is JSValueProtect'ed
  • I wrote TypeScript/JavaScript tests and they pass locally (bun-debug test test-file-name.test)

Resolves #13197

pjeweb added a commit to pjeweb/belaUI that referenced this pull request Feb 12, 2025
pjeweb added a commit to pjeweb/belaUI that referenced this pull request Feb 12, 2025
@pjeweb pjeweb marked this pull request as ready for review February 13, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spawn does not pass empty string as argument
2 participants