Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added API Endpoints for account config #226

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Added API Endpoints for account config #226

merged 1 commit into from
Jun 20, 2024

Conversation

DavidS-ovm
Copy link
Contributor

This is where we will store config like the blast radius limits.

Supersedes #224, relates to https://github.com/overmindtech/api-server/issues/953

@DavidS-ovm
Copy link
Contributor Author

@dylanratcliffe rewrote your content from #224 to go where it was supposed to. the config.proto will also be the home for future user-specific configs, and it'll do us well to keep everything that's working in that corner of the database in one location.

Feel free to merge if you're happy with this.

@dylanratcliffe @DavidS-ovm
Added API Endpoints for account config
04d8cf7 
This is where we will store config like the blast radius limits.

This also moves the experimental CLI config into the correct file to
fix namespacing issues. We need to migrate that into the proper config
service at some point.
@DavidS-ovm
Copy link
Contributor Author

This needed a bunch more work because I originally named the proto package cli, which doesn't make sense now anymore. So this became a lot more juggling than expected...

@DavidS-ovm DavidS-ovm merged commit 33ceb68 into main Jun 20, 2024
1 check passed
@DavidS-ovm DavidS-ovm deleted the blast-radius-limit-config branch June 20, 2024 08:48
@dylanratcliffe
Copy link
Member

@DavidS-ovm Are you able to create the tickets required to migrate this? Changing the package name will require quite a lot of cleanup, and maybe a redirect or something in the server since the endpoint name will change and will break old versions of the CLI

@DavidS-ovm
Copy link
Contributor Author

@dylanratcliffe created overmindtech/cli#414 for a high-level overview of what needs to happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanratcliffe dylanratcliffe dylanratcliffe approved these changes

Assignees

@dylanratcliffe dylanratcliffe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidS-ovm @dylanratcliffe