Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed to correct port #120

Closed
wants to merge 1 commit into from
Closed

Conversation

dylanratcliffe
Copy link
Member

No description provided.

Copy link

github-actions bot commented Jun 4, 2024

mapped Expected Changes

replaced ecs-task-definition › facial-recognition
--- current
+++ planned
@@ -1,26 +1,16 @@
-arn: arn:aws:ecs:eu-west-2:540044833068:task-definition/facial-recognition:48
-arn_without_revision: arn:aws:ecs:eu-west-2:540044833068:task-definition/facial-recognition
-container_definitions: '[{"cpu":1024,"environment":[],"essential":true,"healthCheck":{"command":["CMD-SHELL","wget -q --spider localhost:1234"],"interval":30,"retries":3,"timeout":5},"image":"harshmanvar/face-detection-tensorjs:slim-amd","memory":2048,"mountPoints":[],"name":"facial-recognition","portMappings":[{"appProtocol":"http","containerPort":1234,"hostPort":1234,"protocol":"tcp"}],"volumesFrom":[]}]'
+container_definitions: '[{"cpu":1024,"environment":[],"essential":true,"healthCheck":{"command":["CMD-SHELL","wget -q --spider localhost:8080"],"interval":30,"retries":3,"timeout":5},"image":"harshmanvar/face-detection-tensorjs:slim-amd","memory":2048,"mountPoints":[],"name":"facial-recognition","portMappings":[{"appProtocol":"http","containerPort":1234}],"volumesFrom":[]}]'
 cpu: "1024"
 ephemeral_storage: []
-execution_role_arn: ""
 family: facial-recognition
-id: facial-recognition
 inference_accelerator: []
-ipc_mode: ""
 memory: "2048"
 network_mode: awsvpc
-pid_mode: ""
 placement_constraints: []
 proxy_configuration: []
 requires_compatibilities:
     - FARGATE
-revision: 48
 runtime_platform: []
 skip_destroy: false
-tags: {}
-tags_all: {}
-task_role_arn: ""
 terraform_address: module.loom[0].aws_ecs_task_definition.face
 terraform_name: module.loom[0].aws_ecs_task_definition.face
 track_latest: false

unmapped Unmapped Changes

Note

These changes couldn't be mapped to a discoverable cloud resource and therefore won't be included in the blast radius calculation.

updated aws_ecs_service › module.loom[0].aws_ecs_service.face
--- current
+++ planned
@@ -41,7 +41,6 @@
 service_registries: []
 tags: {}
 tags_all: {}
-task_definition: arn:aws:ecs:eu-west-2:540044833068:task-definition/facial-recognition:48
 terraform_address: module.loom[0].aws_ecs_service.face
 terraform_name: module.loom[0].aws_ecs_service.face
 triggers: {}

Blast Radius

items Items edges Edges
46 49

Open in Overmind

warning Risks

high Potential for ECS Service Disruption on Port Change [High]

The proposed change updates the health check command for the ECS task definition facial-recognition from port 1234 to 8080. Given the current ECS service (arn:aws:ecs:eu-west-2:540044833068:service/example/facial-recognition) is configured with a load balancer target group (arn:aws:elasticloadbalancing:eu-west-2:540044833068:targetgroup/facial-recognition/ec95b63442f95837) that routes traffic to container port 1234, changing the health check command to a different port without ensuring the application is configured to listen on the new port may result in failed health checks. This could lead to ECS marking the service as unhealthy, causing potential disruptions or service restarts. It's critical to verify that the application within the facial-recognition task is set up to accept traffic on port 8080 before applying this change. Additionally, the related load balancer target group settings and ECS service's network configuration might require adjustments to align with the new port, ensuring seamless traffic routing and health check functionality.

high Incompatibility Between Load Balancer and Service Configuration [High]

The current configuration involves a load balancer (arn:aws:elasticloadbalancing:eu-west-2:540044833068:loadbalancer/app/main/e512445409281cdb) that routes traffic to port 1234 of the facial-recognition service. Given the task's container is originally configured to listen on 1234, and the health check is being updated to port 8080, there's potential for misalignment with the current load balancer and ECS service configuration, leading to traffic routing issues. If the application and the load balancer target group are not updated simultaneously to reflect the new port configuration, the deployment may result in the service being inaccessible. Furthermore, the ECS service and related DNS configurations must be closely examined to ensure they're in sync with any changes made to the container port settings to prevent downtime.

medium CloudFront Distribution Configuration Impact [Medium]

While the CloudFront distribution (E19SB692AKYLRW) itself might not be directly affected by the ECS task definition's port change, it's imperative to consider the broader impact on the overall application delivery and caching strategy. The distribution is configured to route traffic to a target origin (likely an application served by the ECS service). Any changes in the port configuration that affect the accessibility or behavior of the application might necessitate corresponding adjustments in the CloudFront distribution settings, particularly the origin and path patterns used for routing requests. Failure to align these configurations could result in HTTP errors, increased latency, or outdated content being served to users. Comprehensive testing and verification post-deployment will be necessary to ensure the CloudFront distribution continues to serve content as expected without interruption.

@dylanratcliffe dylanratcliffe deleted the dylanratcliffe-patch-4 branch June 4, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant