Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for running in multiple demo envs #152

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Fixes for running in multiple demo envs #152

merged 3 commits into from
Aug 1, 2024

Conversation

DavidS-ovm
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Aug 1, 2024

mapped Expected Changes

updated cloudfront-origin-access-control › E2RDYIEX2E5A40
--- current
+++ planned
@@ -1,7 +1,7 @@
 description: Example Policy
 etag: ETVPDKIKX0DER
 id: E2RDYIEX2E5A40
-name: example
+name: example-terraform-example
 origin_access_control_origin_type: s3
 signing_behavior: always
 signing_protocol: sigv4
replaced elbv2-target-group › facial-recognition
--- current
+++ planned
@@ -1,45 +1,37 @@
-arn: arn:aws:elasticloadbalancing:eu-west-2:540044833068:targetgroup/facial-recognition/0e866599c5087011
-arn_suffix: targetgroup/facial-recognition/0e866599c5087011
-connection_termination: null
+arn: (known after apply)
+arn_suffix: (known after apply)
+connection_termination: (known after apply)
 deregistration_delay: "300"
 health_check:
     - enabled: true
       healthy_threshold: 2
       interval: 40
-      matcher: "200"
-      path: /
+      matcher: (known after apply)
+      path: (known after apply)
       port: traffic-port
       protocol: HTTP
       timeout: 30
       unhealthy_threshold: 3
-id: arn:aws:elasticloadbalancing:eu-west-2:540044833068:targetgroup/facial-recognition/0e866599c5087011
-ip_address_type: ipv4
+id: (known after apply)
+ip_address_type: (known after apply)
 lambda_multi_value_headers_enabled: false
-load_balancer_arns:
-    - arn:aws:elasticloadbalancing:eu-west-2:540044833068:loadbalancer/app/terraform-example/fb1fa96c2c59ddef
-load_balancing_algorithm_type: round_robin
-load_balancing_anomaly_mitigation: "off"
-load_balancing_cross_zone_enabled: use_load_balancer_configuration
-name: facial-recognition
-name_prefix: ""
+load_balancer_arns: (known after apply)
+load_balancing_algorithm_type: (known after apply)
+load_balancing_anomaly_mitigation: (known after apply)
+load_balancing_cross_zone_enabled: (known after apply)
+name: facerec-terraform-example
+name_prefix: (known after apply)
 port: 1234
-preserve_client_ip: null
+preserve_client_ip: (known after apply)
 protocol: HTTP
-protocol_version: HTTP1
+protocol_version: (known after apply)
 proxy_protocol_v2: false
 slow_start: 0
-stickiness:
-    - cookie_duration: 86400
-      cookie_name: ""
-      enabled: false
-      type: lb_cookie
-tags: {}
-tags_all: {}
-target_failover:
-    - on_deregistration: null
-      on_unhealthy: null
-target_health_state:
-    - enable_unhealthy_connection_termination: null
+stickiness: (known after apply)
+tags: null
+tags_all: (known after apply)
+target_failover: (known after apply)
+target_health_state: (known after apply)
 target_type: ip
 terraform_address: module.loom[0].aws_lb_target_group.face
 terraform_name: module.loom[0].aws_lb_target_group.face
replaced elbv2-target-group › visit-counter
--- current
+++ planned
@@ -1,45 +1,28 @@
-arn: arn:aws:elasticloadbalancing:eu-west-2:540044833068:targetgroup/visit-counter/7317f14148bf372d
-arn_suffix: targetgroup/visit-counter/7317f14148bf372d
-connection_termination: null
+arn: (known after apply)
+arn_suffix: (known after apply)
+connection_termination: (known after apply)
 deregistration_delay: "300"
-health_check:
-    - enabled: true
-      healthy_threshold: 5
-      interval: 30
-      matcher: "200"
-      path: /
-      port: traffic-port
-      protocol: HTTP
-      timeout: 5
-      unhealthy_threshold: 2
-id: arn:aws:elasticloadbalancing:eu-west-2:540044833068:targetgroup/visit-counter/7317f14148bf372d
-ip_address_type: ipv4
+health_check: (known after apply)
+id: (known after apply)
+ip_address_type: (known after apply)
 lambda_multi_value_headers_enabled: false
-load_balancer_arns:
-    - arn:aws:elasticloadbalancing:eu-west-2:540044833068:loadbalancer/app/terraform-example/fb1fa96c2c59ddef
-load_balancing_algorithm_type: round_robin
-load_balancing_anomaly_mitigation: "off"
-load_balancing_cross_zone_enabled: use_load_balancer_configuration
-name: visit-counter
-name_prefix: ""
+load_balancer_arns: (known after apply)
+load_balancing_algorithm_type: (known after apply)
+load_balancing_anomaly_mitigation: (known after apply)
+load_balancing_cross_zone_enabled: (known after apply)
+name: visit-counter-terraform-example
+name_prefix: (known after apply)
 port: 80
-preserve_client_ip: null
+preserve_client_ip: (known after apply)
 protocol: HTTP
-protocol_version: HTTP1
+protocol_version: (known after apply)
 proxy_protocol_v2: false
 slow_start: 0
-stickiness:
-    - cookie_duration: 86400
-      cookie_name: ""
-      enabled: false
-      type: lb_cookie
-tags: {}
-tags_all: {}
-target_failover:
-    - on_deregistration: null
-      on_unhealthy: null
-target_health_state:
-    - enable_unhealthy_connection_termination: null
+stickiness: (known after apply)
+tags: null
+tags_all: (known after apply)
+target_failover: (known after apply)
+target_health_state: (known after apply)
 target_type: ip
 terraform_address: module.loom[0].aws_lb_target_group.visit_counter
 terraform_name: module.loom[0].aws_lb_target_group.visit_counter

unmapped Unmapped Changes

Note

These changes couldn't be mapped to a discoverable cloud resource and therefore won't be included in the blast radius calculation.

updated aws_ecs_service › module.loom[0].aws_ecs_service.face
--- current
+++ planned
@@ -23,7 +23,7 @@
     - container_name: facial-recognition
       container_port: 1234
       elb_name: ""
-      target_group_arn: arn:aws:elasticloadbalancing:eu-west-2:540044833068:targetgroup/facial-recognition/0e866599c5087011
+      target_group_arn: (known after apply)
 name: facial-recognition
 network_configuration:
     - assign_public_ip: false
updated aws_ecs_service › module.loom[0].aws_ecs_service.visit_counter
--- current
+++ planned
@@ -23,7 +23,7 @@
     - container_name: visit-counter
       container_port: 80
       elb_name: ""
-      target_group_arn: arn:aws:elasticloadbalancing:eu-west-2:540044833068:targetgroup/visit-counter/7317f14148bf372d
+      target_group_arn: (known after apply)
 name: visit-counter
 network_configuration:
     - assign_public_ip: false
updated elbv2-rule › module.loom[0].aws_lb_listener_rule.face
--- current
+++ planned
@@ -5,7 +5,7 @@
       forward: []
       order: 1
       redirect: []
-      target_group_arn: arn:aws:elasticloadbalancing:eu-west-2:540044833068:targetgroup/facial-recognition/0e866599c5087011
+      target_group_arn: (known after apply)
       type: forward
 arn: arn:aws:elasticloadbalancing:eu-west-2:540044833068:listener-rule/app/terraform-example/fb1fa96c2c59ddef/929045abf7a1e46a/eac24e0d64f18dbe
 condition:
updated elbv2-rule › module.loom[0].aws_lb_listener_rule.visit_counter
--- current
+++ planned
@@ -5,7 +5,7 @@
       forward: []
       order: 1
       redirect: []
-      target_group_arn: arn:aws:elasticloadbalancing:eu-west-2:540044833068:targetgroup/visit-counter/7317f14148bf372d
+      target_group_arn: (known after apply)
       type: forward
 arn: arn:aws:elasticloadbalancing:eu-west-2:540044833068:listener-rule/app/terraform-example/fb1fa96c2c59ddef/929045abf7a1e46a/c1bb1b576d9a6aa6
 condition:

Blast Radius

items Items edges Edges
7 4

Open in Overmind

warning Risks

high Risk of Service Disruption due to Target Group Name Change for Facial Recognition [High]

The target group name for the 'facial-recognition' service is being changed from 'facial-recognition' to 'facerec-terraform-example'. This change could disrupt the service if there are any scripts, monitoring tools, or configurations that specifically rely on the old target group name. Ensuring that all references are updated accordingly is essential to prevent service disruptions.

high Risk of Service Disruption due to Target Group Name Change for Visit Counter [High]

The target group name for the 'visit-counter' service is being changed from 'visit-counter' to 'visit-counter-terraform-example'. Similar to the facial recognition service, this could disrupt the visit counter service if there are dependencies on the old name in scripts, monitoring tools, or configurations. All references should be updated to reflect the new name to avoid any service outages.

medium Potential Misconfiguration in CloudFront Origin Access Control Name [Medium]

The proposed change updates the name of the CloudFront Origin Access Control from 'example' to 'example-terraform-example'. While this change alone seems benign, any dependent services or configurations that reference the name 'example' may break if they are not updated simultaneously. This could lead to issues with access control, resulting in potential outages or unauthorized access.

@DavidS-ovm DavidS-ovm merged commit 638cf29 into main Aug 1, 2024
3 checks passed
@DavidS-ovm DavidS-ovm deleted the fixes branch August 1, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant