Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create new bucket notification to same bucket #85

Closed
wants to merge 1 commit into from

Conversation

jameslaneovermind
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Mar 5, 2024

mapped Expected Changes

No expected changes found.

Blast Radius

items Items edges Edges
0 0

Open in Overmind

warning Risks

medium Duplicate Notifications [Medium]

Given the addition of aws_s3_bucket_notification.new_bucket_notification, without clear evidence of the current system's state or existing notification configurations, there's a risk of creating duplicate notifications. This can happen if there's already a notification setup with similar event types (s3:ObjectCreated:*) pointing to the same SQS queue (aws_sqs_queue.my_queue). Duplicate notifications could lead to redundant data processing, potentially doubling the workload and associated processing costs. Verifying the non-existence of similar notification configurations in the current state can mitigate this risk.

low Improper Queue Policy Configuration [Low]

The update to aws_sqs_queue_policy.my_queue_policy indicates that it's potentially being modified to allow the new S3 bucket notification to publish events. Assuming the current configuration is working and has correct permissions in place, there's a low risk that the update might inadvertently alter permissions in a way that disrupts existing flows or fails to allow the new S3 notification events through. The risk remains low if the changes are carefully reviewed against current permissions to ensure they're additive rather than subtractive or altering in nature.

medium Notification Configuration Error [Medium]

If the aws_s3_bucket_notification.new_bucket_notification's configuration is mismatched against the intended target or event types, there could be disruptions in the event notification system. Assuming the current system is working correctly, introducing a new notification with incorrect parameters could lead to missed events or unwanted traffic to the SQS queue. It is critical to validate queue_arn and the events array against intended targets and event types, especially in a working system where the introduction of new components comes with the assumption of expanding or refining functionality without disruption.

@jameslaneovermind jameslaneovermind deleted the new_bucket_notif branch March 20, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant