-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style/#289 acknowledgement page responsive css #293
Style/#289 acknowledgement page responsive css #293
Conversation
@@ -0,0 +1,34 @@ | |||
import React from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is of the next ticket, Products Page Update. Not sure why it appears in this ticket. I made sure I closed old tabs and then switch local branches.
@@ -0,0 +1,58 @@ | |||
@import '../../styles/colors'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Belong to next ticket, Products Page Update
@daniel-cy-lu curious why we're moving away from using the |
This discussion extended to a zoom chat, and we decided to use a modified Hero component best suited for the current version of the Hero. Cleaned up Hero component and its css. |
@ciaranschutte I cleaned up all the comments and found a lot of unused css in the case study page, and got rid of those as well. |
Because we modified Hero component, currently Services and About Us pages don't have a Hero image nor css applied. These two pages however are going to receive complete re-design. |
|
@daniel-cy-lu looks great. nice cleanup. just ensure that's not duplicate image then good to go! |
@daniel-cy-lu couple of things I noticed in reviewing, but aren't changes in this PR, so I've made a ticket to detail them: #305 |
@ciaranschutte I read the new ticket, I will double check the font size and font of |
Acknowledgement Page, which can be found via the link in the footer. Responsive CSS completed for mobile, tablet and desktop.
Refer to Patrick's mock up: https://www.figma.com/proto/fXh58MfxEDh1ssgxQyPb5f/Overture_Refresh?type=design&node-id=1159-10536&t=B0eRBTRc8HE2PXBM-0&scaling=min-zoom&page-id=1098%3A3803&starting-point-node-id=1167%3A12310
Patrick has no MVP feedback for this page.