fix(pci): null instance price (#3864)

`CucPriceHelper.getPrices` is throwing an error, that wasn't catched in the routing causing the whole instance page to be in error. ref: DTRSD-22103 Signed-off-by: frenauvh <[email protected]>
ovh · Oct 19, 2020 · cd62472 · cd62472
1 parent 3b66c5d
commit cd62472
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 11 deletions.
diff --git a/packages/manager/modules/pci/src/projects/project/instances/instance/instance.html b/packages/manager/modules/pci/src/projects/project/instances/instance/instance.html
@@ -203,6 +203,7 @@
                 </div>
 
                 <oui-tile-definition
+                    data-ng-if="$ctrl.instancePrice.price"
                     data-term="{{:: 'pci_projects_project_instances_instance_price_label' | translate }}"
                 >
                     <oui-tile-description>

diff --git a/packages/manager/modules/pci/src/projects/project/instances/instances.service.js b/packages/manager/modules/pci/src/projects/project/instances/instances.service.js
@@ -352,18 +352,20 @@ export default class PciProjectInstanceService {
   }
 
   getInstancePrice(projectId, instance) {
-    return this.CucPriceHelper.getPrices(projectId).then((prices) => {
-      const price = prices[instance.planCode];
-      // Set 3 digits for hourly price
-      if (!instance.isMonthlyBillingActivated()) {
-        price.price.text = price.price.text.replace(
-          /\d+(?:[.,]\d+)?/,
-          `${price.price.value.toFixed(3)}`,
-        );
-      }
+    return this.CucPriceHelper.getPrices(projectId)
+      .then((prices) => {
+        const price = prices[instance.planCode];
+        // Set 3 digits for hourly price
+        if (!instance.isMonthlyBillingActivated()) {
+          price.price.text = price.price.text.replace(
+            /\d+(?:[.,]\d+)?/,
+            `${price.price.value.toFixed(3)}`,
+          );
+        }
 
-      return price;
-    });
+        return price;
+      })
+      .catch(() => null);
   }
 
   getProjectQuota(projectId, region = null) {