Load icons from custom directory. #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if your icons are located in directory other that `blade-fontawesome`, Factory will throw an error complaining that "path" for a set does not exist. This happens because BladeUIKit package creates "paths" for sets the first time it create Factory. Since this package hooks up to BladeUIKit when its Factory is already instantiated "paths" key for icon sets is not filled. Ideally, I'd look to update BladeUIKit Factory itself, but it won't hurt to manually sets paths in this library.
|
this would be a really useful feature to have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if your icons are located in directory other that
blade-fontawesome, Factory will throw an error complaining that "path" for a set does not exist. This happens because BladeUIKit package creates "paths" for sets the first time it create Factory. Since this package hooks up to BladeUIKit when its Factory is already instantiated "paths" key for icon sets is not filled.Ideally, I'd look to update BladeUIKit Factory itself, but it won't hurt to manually sets paths in this library.
...