Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ deduplicate unit in axis labels / TAS-810 #4443

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Jan 13, 2025

Deemphasis text in parentheses. For example, in the screenshot below "male" and "female" are deemphasised.

Screenshot 2025-01-13 at 16 44 38

This is part 4 of 4 in a stack made with GitButler:

@github-actions github-actions bot added the staging-viz Let SVG tester fail silently in CI label Jan 13, 2025
@sophiamersmann sophiamersmann marked this pull request as ready for review January 13, 2025 15:47
@sophiamersmann sophiamersmann changed the title ✨ deemphasise label text in parens ✨ deemphasise label text in parens / TAS-810 Jan 13, 2025
Copy link

@sophiamersmann sophiamersmann force-pushed the improve-axis-label-unit branch from 46f8024 to 9e4b4cd Compare January 14, 2025 08:36
@owidbot
Copy link
Contributor

owidbot commented Jan 14, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-improve-axis-label-unit

SVG tester:

Number of differences (default views): 25 (62b903) ❌
Number of differences (all views): 16 (ae007f) ❌

Edited: 2025-01-21 14:30:08 UTC
Execution time: 1.34 seconds

@sophiamersmann sophiamersmann marked this pull request as draft January 20, 2025 09:52
@sophiamersmann sophiamersmann force-pushed the axis-label-unit branch 3 times, most recently from 76b48e2 to 910deab Compare January 21, 2025 12:34
Base automatically changed from axis-label-unit to master January 21, 2025 13:04
@sophiamersmann sophiamersmann force-pushed the improve-axis-label-unit branch 4 times, most recently from fd5810e to 5908fff Compare January 21, 2025 14:12
@sophiamersmann sophiamersmann changed the title ✨ deemphasise label text in parens / TAS-810 ✨ deduplicate unit in axis labels / TAS-810 Jan 21, 2025
@sophiamersmann sophiamersmann marked this pull request as ready for review January 21, 2025 15:19
@sophiamersmann sophiamersmann merged commit 9111163 into master Jan 21, 2025
23 checks passed
@sophiamersmann sophiamersmann deleted the improve-axis-label-unit branch January 21, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging-viz Let SVG tester fail silently in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants