Reduce number of resource jobs during periodic auto-refresh of spaces #12060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essentially this commit drastically reduces image updates and associated ResourceJob creation by checking the etag of the image and only fetching the resource if the tag has changed. same principle is applied to the space itself. Space's drive is "updated" automatically every 30 seconds using a polling strategy, so it's common that nothing has actually changed. New behavior: if the space etag has not changed there should be nothing to update, so skip it.
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
|
modSpike
changed the title
erikjv
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
essentially this commit drastically reduces image updates and associated ResourceJob creation by checking the etag of the image and only fetching the resource if the tag has changed.
same principle is applied to the space itself. Space's drive is "updated" automatically every 30 seconds using a polling strategy, so it's common that nothing has actually changed. New behavior: if the space etag has not changed there should be nothing to update, so skip it.