use application shortname to create installer icon #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to `craft --package owncloud-client` I get this error:
```
Processing config: C:\Users\{...}\ownbuild\ownbuild\5\windows-cl-msvc2022-x86_64\dev-utils\nsis\nsisconf.nsh
Processing script file: "C:\_\fcafd268\owncloud-client.nsi" (ACP)
Error while loading icon from "C:\_\fcafd268\build\src\gui\owncloud.ico": can't open file
Error in macro MUI_INTERFACE on macroline 86
Error in macro MUI_PAGE_INIT on macroline 7
Error in macro MUI_PAGE_WELCOME on macroline 5
Error in script "C:\_\fcafd268\owncloud-client.nsi" on line 98 -- aborting creation process
Command ['C:\\Users\\{...}\\ownbuild\\ownbuild\\5\\windows-cl-msvc2022-x86_64\\dev-utils\\bin\\makensis.exe', '/V3', 'C:\\_\\fcafd268\\owncloud-client.nsi'] failed with exit code 1
Error in makensis execution
Action: package for owncloud/owncloud-client:master FAILED
*** Craft package failed: owncloud/owncloud-client after 22 seconds ***
```
I am using a theme with `craft --set args="-DOEM_THEME_DIR=C:/{...}/ownbuild/junidrive/mirall" owncloud-client`
This PR lets me continue the packaging ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to
craft --package owncloud-clientI get this error:I am using a theme with
craft --set args="-DOEM_THEME_DIR=C:/{...}/ownbuild/junidrive/mirall" owncloud-clientThis PR lets me continue the packaging ;-)