Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename make test-php to test-php-unit #661

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Rename make test-php to test-php-unit #661

merged 1 commit into from
Feb 28, 2019

Conversation

phil-davis
Copy link
Contributor

Issue #660

due to core PR owncloud/core#34638

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@phil-davis
Copy link
Contributor Author

@settermjd this is an interesting case for what to backport.

For changes to the ongoing day-to-day developer environment, we want the developers to be able to find the up-to-date documentation. But we do not want to backport this to 10.1 because actually if a developer checks out the v10.1.0 tag and tries to make test-php-unit then it will not work.

So in this case we do want the "master" documentation to be findable online.

@phil-davis phil-davis merged commit 945faed into master Feb 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the test-php-unit branch February 28, 2019 14:50
@mmattel
Copy link
Contributor

mmattel commented Mar 7, 2019

Is backporting required ?

@phil-davis
Copy link
Contributor Author

phil-davis commented Mar 8, 2019

If you are a developer and have actually checked out a 10.1 or 10.0 branch:

git checkout v10.1.0
git checkout v10.0.10

then you have to use the previous make test-php to run the unit tests.

If you are using a current in-development branch (which developers will be doing 99% of the time):

git checkout stable10
git checkout master

then you have to type make test-php-unit

This is an example where we do not backport, but where the "current fluid docs master" needs to be published so that developers can see doc of the current development environment. And developers need to understand that they should usually look at "docs master" when reading developer docs.

@mmattel
Copy link
Contributor

mmattel commented Mar 8, 2019

Your text is very clear and informative.
Could this be somehow adopted to be a unified text for all doc branches?
That would be imho very helpful and would avoid confusion - or?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants