[tests-only][full-ci] add tests for checking the header location for tus upload #10807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabim777
force-pushed
the
tests/check-header-location-for-tus-upload
branch
from
b79bb57 to
e9d5edd
Compare
9 tasks
nabim777
force-pushed
the
tests/check-header-location-for-tus-upload
branch
2 times, most recently
from
e61de04 to
c78d8a1
Compare
9 tasks
Signed-off-by: nabim777 <[email protected]>
Signed-off-by: nabim777 <[email protected]>
Signed-off-by: nabim777 <[email protected]>
nabim777
force-pushed
the
tests/check-header-location-for-tus-upload
branch
from
c78d8a1 to
0ec975d
Compare
nabim777
requested review from
saw-jan,
anon-pradip,
prashant-gurung899,
Salipa-Gurung,
amrita-shrestha,
S-Panta,
PrajwolAmatya and
nirajacharya2
saw-jan
requested changes
Jan 3, 2025
nabim777
force-pushed
the
tests/check-header-location-for-tus-upload
branch
from
ee5defd to
91ea534
Compare
nabim777
force-pushed
the
tests/check-header-location-for-tus-upload
branch
from
91ea534 to
0842b80
Compare
nabim777
force-pushed
the
tests/check-header-location-for-tus-upload
branch
from
0842b80 to
d592bae
Compare
Signed-off-by: nabim777 <[email protected]>
nabim777
force-pushed
the
tests/check-header-location-for-tus-upload
branch
2 times, most recently
from
b56281f to
b8211ed
Compare
Signed-off-by: nabim777 <[email protected]>
nabim777
force-pushed
the
tests/check-header-location-for-tus-upload
branch
2 times, most recently
from
918dca1 to
d5b8065
Compare
Signed-off-by: nabim777 <[email protected]>
nabim777
force-pushed
the
tests/check-header-location-for-tus-upload
branch
from
d5b8065 to
abcb354
Compare
SagarGi
reviewed
Jan 7, 2025
nabim777
force-pushed
the
tests/check-header-location-for-tus-upload
branch
2 times, most recently
from
5e17628 to
f858b02
Compare
S-Panta
reviewed
Jan 7, 2025
S-Panta
reviewed
Jan 7, 2025
nabim777
force-pushed
the
tests/check-header-location-for-tus-upload
branch
from
f858b02 to
373c077
Compare
nabim777
force-pushed
the
tests/check-header-location-for-tus-upload
branch
from
373c077 to
db2f7b6
Compare
Signed-off-by: nabim777 <[email protected]>
nabim777
force-pushed
the
tests/check-header-location-for-tus-upload
branch
from
db2f7b6 to
c860b81
Compare
saw-jan
reviewed
Jan 14, 2025
| @@ -309,7 +320,7 @@ public function uploadFileUsingTus( | |||
| $headers = \array_merge($headers, $checksumHeader); | |||
| } | |||
|
|
|||
| $client = new Client( | |||
| $tusClient = new TusClient( | |||
There was a problem hiding this comment.
Suggested change
| $tusClient = new TusClient( | |
| $client = new TusClient( |
| * @throws GuzzleException | ||
| * @throws ReflectionException | ||
| */ | ||
| public function publicUploadFileUsingTus( |
There was a problem hiding this comment.
can we use the above existing method (update if necessary)?
Signed-off-by: nabim777 <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since current test uses TUS library for tus operations and is unable to get and check the response.
Due to this, there was no check for the location header on TUS upload.
So, in this PR, following things are done:
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: