Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]adding test for sharing space via secure role #9311

Merged
merged 1 commit into from
Jun 6, 2024
Merged

[tests-only][full-ci]adding test for sharing space via secure role #9311

merged 1 commit into from
Jun 6, 2024

Conversation

S-Panta
Copy link
Contributor

@S-Panta S-Panta commented Jun 4, 2024 •
edited
Loading

Description

This PR covers the scenario in various feature file to add secure viewer role while sharing the space.

Related Issue

How Has This Been Tested?

  • test environment:
  • locally and CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@S-Panta S-Panta self-assigned this Jun 4, 2024
@S-Panta S-Panta added the QA:team label Jun 4, 2024
@S-Panta S-Panta force-pushed the add-secure-role-for-sharing-space branch 2 times, most recently from 4be67c3 to f21cae8 Compare June 5, 2024 04:22
@S-Panta S-Panta mentioned this pull request Jun 5, 2024
Closed
27 tasks
@S-Panta S-Panta force-pushed the add-secure-role-for-sharing-space branch from f21cae8 to 542712b Compare June 5, 2024 06:32
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@S-Panta S-Panta marked this pull request as ready for review June 6, 2024 04:12
amrita-shrestha
amrita-shrestha approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@S-Panta S-Panta merged commit 87a2da7 into master Jun 6, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the add-secure-role-for-sharing-space branch June 6, 2024 06:34
ownclouders pushed a commit that referenced this pull request Jun 6, 2024
@S-Panta
adding secure view to list permission for shared space (#9311)
25cf4a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrita-shrestha amrita-shrestha amrita-shrestha approved these changes

@saw-jan saw-jan Awaiting requested review from saw-jan

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

Assignees

@S-Panta S-Panta

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@S-Panta @amrita-shrestha