Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while reloading the page after editing password of a public link share for .txt file #12113

Open
anon-pradip opened this issue Jan 17, 2025 · 4 comments
Assignees
Labels
Type:Bug Something isn't working

Comments

@anon-pradip
Copy link
Contributor

Describe the bug

After editing the password of a public link share of a .txt file and refreshing the page on the sharee side, the page shows username or password incorrect error despite showing the new password input screen.

Steps to reproduce

  1. user Alice uploads a text file file.txt
  2. Alice creates a public link for that file with a password
  3. public opens that link in the incognito tab
  4. Alice edits the link with a new password
  5. public refreshes the page

Expected behavior

"new password prompt" screen should be shown.

Actual behavior

"username or password was incorrect" screen is shown:

Image

Setup

@anon-pradip anon-pradip added the Type:Bug Something isn't working label Jan 17, 2025
@anon-pradip anon-pradip changed the title TXT file fails to load after editing linked share password Error while reloading the page after editing password of a public link share for .txt file Jan 17, 2025
@LukasHirt LukasHirt self-assigned this Jan 17, 2025
@LukasHirt
Copy link
Collaborator

LukasHirt commented Jan 20, 2025

I'm having troubles to reproduce it with local env. I see the error when running the binary from the testing URL but if I try to run it locally with the stable tags, instead of opening the text editor where the bug happens, the link shows file info which on refresh works correctly.

@anon-pradip
Copy link
Contributor Author

anon-pradip commented Jan 21, 2025

Hi @LukasHirt, I ran with the following setup:

  1. stable ocis & stable web (meaning web which comes while running ocis, not building ourselves) =>OCIS_IMAGE=owncloud/ocis:7.0.0 docker compose up => this gives: Infinite Scale 7.0.0 Community and ownCloud Web UI 11.0.6
  2. stable ocis & latest web (meaning pulled latest changes and built) => OCIS_IMAGE=owncloud/ocis:7.0.0 docker compose up => this gives: Infinite Scale 7.0.0 Community and ownCloud Web UI 11.1.0
  3. ocis=7.1 rc2 & stable web => OCIS_IMAGE=owncloud/ocis:7.1.0-rc.2 docker compose up => this gives Infinite Scale 7.1.0-rc.2 Community and ownCloud Web UI 11.1.0
  4. stable ocis & latest web => OCIS_IMAGE=owncloud/ocis:7.1.0-rc.2 docker compose up => Infinite Scale 7.1.0-rc.2 Community and ownCloud Web UI 11.1.0
  5. Also tried with ocis:7.1.0-rc.2 binary image.

In all steps, the same error persists. Thanks 😺

@saw-jan
Copy link
Member

saw-jan commented Jan 21, 2025

That means it is not a regression in web-11.1.0, so should we target the fix for ocis-7.1 or upcoming next release?

@LukasHirt
Copy link
Collaborator

We're going to postpone this to the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working
Projects
Status: Qualification
Development

No branches or pull requests

3 participants