Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add translations for People-Panel > Roles-Menu #6460

Closed
tbsbdr opened this issue Feb 21, 2022 · 2 comments · Fixed by #6811
Closed

Add translations for People-Panel > Roles-Menu #6460

tbsbdr opened this issue Feb 21, 2022 · 2 comments · Fixed by #6811
Labels
Priority:p3-medium Normal priority Topic:good-first-issue beginner friendly task Type:Bug Something isn't working

Comments

@tbsbdr
Copy link

tbsbdr commented Feb 21, 2022

Steps to reproduce

  1. Use a browser with "German" set as language
  2. login to demo.owncloud.com (-> new Design)
  3. Rightclick on a file, choose "share"
  4. click on "Als viewer einladen", see roles and descriptions in english

Expected behaviour

Roles and descriptions should be displayed according to the browser setting (in our example German)

Actual behaviour

Roles and descriptions are displayed in english

image
@tbsbdr tbsbdr added Type:Bug Something isn't working Priority:p3-medium Normal priority labels Feb 21, 2022
@pascalwengerter
Copy link
Contributor

I did some investigating and from what I've seen gettext doesn't get triggered correctly from inside *.ts files 🕵🏽

@pascalwengerter
Copy link
Contributor

I did some investigating and from what I've seen gettext doesn't get triggered correctly from inside *.ts files 🕵🏽

Also, seems a bit stale in the used project(s) Polyconseil/vue-gettext#107 and seems to be resolved in its successor jshmrtn/vue3-gettext#4

@fschade fschade added the Topic:good-first-issue beginner friendly task label Mar 4, 2022
@pascalwengerter pascalwengerter mentioned this issue Apr 8, 2022
Closed
@AlexAndBear AlexAndBear mentioned this issue Apr 25, 2022
Merged
10 tasks
@kulmann kulmann moved this to Done in Web Support Board Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority:p3-medium Normal priority Topic:good-first-issue beginner friendly task Type:Bug Something isn't working
Projects
No open projects
Web Support Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

l10n for typescript files owncloud/web
3 participants
@pascalwengerter @tbsbdr @fschade