-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add extension point for application menu items #11258
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
41f1472
to
6f95ef8
Compare
This currently only supports remix icons. Do we need support for icon urls? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I do a production build there is a vue-router error when navigating into an embedded wikipedia.com
. doesn't happen with vite 🤔 (tested together with a production build of owncloud/web-extensions#13 in my ocis apps folder)
packages/web-pkg/src/composables/piniaStores/extensionRegistry/types.ts
Outdated
Show resolved
Hide resolved
Adds an extension point for adding items in the top left application switcher menu. `AppMenuItemExtension`'s can either link to an internal page (via `path`), an external page (via `url`) or have a button handler (via `handler`). Please refer to the docs for more information. This deprecates the `applicationMenu` property of the appinfo object. Also removes ancient menu logic from oC10 times, such as the user menu.
6f95ef8
to
5819b2b
Compare
Huh, there was an issue with the way I've added the router component. I don't get why this didn't pop up in dev mode... anyway, now it should work (although you need to edit your server's CSP rules to allow an external site being embedded via an iFrame). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm... did I overlook something or is an isVisible
callback missing? There are apps, e.g. the admin-settings
app, which are only visible to certain users.
Do we need it though? Since it will be the app's duty to register menu items, it can just not register an item if the user doesn't have permissions to see it. |
Co-authored-by: Benedikt Kulmann <[email protected]>
Hm true... |
|
…point feat: add extension point for application menu items
Description
Adds an extension point for adding items in the top left application switcher menu.
AppMenuItemExtension
's can either link to an internal page (viapath
), an external page (viaurl
) or have a button handler (viahandler
). Please refer to the docs for more information.This deprecates the
applicationMenu
property of the appinfo object.Also removes ancient menu logic from oC10 times, such as the user menu.
Related Issue
Types of changes