Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/refactor to script setup #12174

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

mzner
Copy link
Contributor

@mzner mzner commented Feb 11, 2025

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

Copy link

update-docs bot commented Feb 11, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@CLAassistant
Copy link

CLAassistant commented Feb 11, 2025

CLA assistant check
All committers have signed the CLA.

@mzner mzner requested a review from LukasHirt February 11, 2025 08:36
@mzner mzner force-pushed the chore/refactor-to-script-setup branch from e459477 to 53ec234 Compare February 11, 2025 09:30
@mzner mzner force-pushed the chore/refactor-to-script-setup branch from 53ec234 to 0f19ba5 Compare February 17, 2025 13:57
@mzner mzner marked this pull request as ready for review February 17, 2025 13:59
@LukasHirt
Copy link
Collaborator

selectedType.value = type
}

const generatePasswordMethod = () => passwordPolicyService.generatePassword()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess with setup we can use the function directly without wrapping it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants