feat(api): add array #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcvz
reviewed
Apr 17, 2024
minghuaw
commented
Apr 17, 2024
dcvz
approved these changes
Apr 17, 2024
minghuaw
added a commit
that referenced
this pull request
Jul 16, 2024
* deny unused_unsafe * init impl of rust wrapper of array * moved TODO * fmt and fix clippy * rename c64 to complex64 and itemsize() to item_size() * rename ptr to c_array * restore Clone and Copy derive for Dtype * added 2d array unit test * moved Dtype to mod dtype * fn from_slice infer dim from shape * check dim in rust * as_slice returns None if not evaled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial implementation of the safe rust wrapper of mlx array.
Below are some problems found that should probably be discussed (and hopefully resolved)
Arraytype should probably NOT implement theClonetrait? Because the c struct mlx_array is atomically reference counted but not protected byMutexnum_complex::Complex<f32>,c64(the current one) orcomplex64.Complex64should probably be avoided becausenum_complex::Complex64is actuallynum_complex::Complex<f64>There is one thing that we probably want to double check after implementing ops
For
mlx_array_data_*methods, the mlx doc says