Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): impl Clone and Debug for Device and Stream #40

Merged
merged 2 commits into from
Apr 21, 2024

Conversation

minghuaw
Copy link
Collaborator

  1. Added Clone impl for Device, Stream, and StreamOrDevice
  2. Deny missing_debug_implementations (pub types that don't have Debug impl will give an compile error`)

@minghuaw minghuaw requested a review from dcvz April 21, 2024 03:22
Copy link
Contributor

@dcvz dcvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 some small comments

src/device.rs Show resolved Hide resolved
src/stream.rs Show resolved Hide resolved
@minghuaw minghuaw merged commit 5b7ceb5 into dev Apr 21, 2024
3 checks passed
@dcvz dcvz deleted the api/clone_stream_or_device branch May 7, 2024 07:52
minghuaw added a commit that referenced this pull request Jul 16, 2024
* impl Clone for Device, Stream & StreamOrDevice

* deny missing_debug_impl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants