lib: emulate Hyper-V enlightenment stack #849
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjcolombo
commented
Feb 5, 2025
crates/propolis-api-types/src/instance_spec/components/board.rs
Outdated
Show resolved
Hide resolved
hawkw
approved these changes
Feb 5, 2025
crates/propolis-api-types/src/instance_spec/components/board.rs
Outdated
Show resolved
Hide resolved
iximeow
reviewed
Feb 5, 2025
pfmooney
reviewed
Feb 5, 2025
|
Thanks for addressing the review feedback, the new changes look good! |
pfmooney
reviewed
Feb 6, 2025
| const LOCKED_MASK: u64 = 1 << LOCKED_BIT; | ||
| const ENABLED_BIT: u64 = 0; | ||
| const ENABLED_MASK: u64 = 1 << ENABLED_BIT; | ||
| const GPA_MASK: u64 = !((1 << PAGE_SHIFT) - 1); |
There was a problem hiding this comment.
Could use PAGE_MASK here, or in place of GPA_MASK all together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the beginnings of a Hyper-V enlightenment stack to complement the bhyve enlightenment stack. This change aims to provide the absolute minimum functionality needed for a hypervisor to claim to expose a Hyper-V-compatible guest-hypervisor interface. These minimum requirements are described in the doc comments throughout this change.
Add PHD tests that boot VMs with the Hyper-V enlightenment stack enabled and (if the guest supports it) that try to query the hypervisor interface from within the guest.
Add a simple
propolis-clioption to enable the Hyper-V stack. Once the stack has some actual features, this may be better expressed as a table in thepropolis-config-tomlcrate, but this gives users a quick and easy way to enable the new interface.Tests: PHD with Debian 11, Ubuntu 22.04, Alpine, and Windows Server 2022 guests; repeated the Debian 11 and WS2022 runs with the Hyper-V enlightenment stack enabled by default for all PHD VMs. Tested with an ad hoc Debian 11 VM, verifying that it detected the Hyper-V hypervisor, that the guest wrote appropriate values to the Hyper-V MSRs, and (through mdb-bhyve) that the correct instruction sequence appears on the guest's hypercall page.
Related to #328.