feat(linter): add codespell linter #4143
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ideaship
requested review from
nvuillam,
echoix,
bdovaz and
Kurt-von-Laven
as code owners
ideaship
force-pushed
the
rl_add_codespell
branch
from
f69ce60
to
f2c2fa3
Compare
ideaship
force-pushed
the
rl_add_codespell
branch
from
f2c2fa3
to
04dd611
Compare
ideaship
force-pushed
the
rl_add_codespell
branch
from
04dd611
to
0577625
Compare
ideaship
force-pushed
the
rl_add_codespell
branch
from
0577625
to
41077c0
Compare
|
@nvuillam The PR I created is failing for reasons that are not obvious to me. I will hopefully get around to take another look tomorrow. Hints welcome. |
nvuillam
reviewed
Oct 16, 2024
| @@ -211,3 +211,39 @@ linters: | |||
| dockerfile: | |||
| - FROM lycheeverse/lychee:latest-alpine AS lychee | |||
| - COPY --link --from=lychee /usr/local/bin/lychee /usr/bin/ | |||
|
|
|||
Add the codespell linter which uses a dictionary of common misspellings and ignores unknown words. Signed-off-by: Roger Luethi <[email protected]>
Try if this helps workflow find test files. Signed-off-by: Roger Luethi <[email protected]>
Signed-off-by: Roger Luethi <[email protected]>
ideaship
force-pushed
the
rl_add_codespell
branch
from
6f40e6d
to
4a72ed8
Compare
|
@nvuillam It looks to me like the Tests + Deploy Docker Image - DEV check failed for reasons unrelated to the PR. I don't see why shfmt and markdown-link-check should fail. The MegaLinter failed because cspell finds misspelled words in the I am not sure whether I should add the words in I can implement changes, but I need some guidance on how to proceed to match the project's expectations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the codespell linter which uses a dictionary of common misspellings and ignores unknown words.
Fixes #4140
Proposed Changes
Add the codespell linter which uses a dictionary of common misspellings and ignores unknown words.
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breakingif this is a large fundamental changeautomation,bug,documentation,enhancement,infrastructure, orperformance