-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Create/CreateBeta method #634
Open
pzhao5
wants to merge
9
commits into
master
Choose a base branch
from
pzhao007
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfornea
reviewed
Nov 2, 2018
rfornea
reviewed
Nov 2, 2018
rfornea
reviewed
Nov 2, 2018
/*GetObjectKeyForData will return object key for particular data. startIndex is the smallest index in data. */ | ||
func GetObjectKeyForData(genesisHash string, startIndex int, totalCount int, isReserveIteration bool, batchSize int) string { | ||
index := 0 | ||
if isReserveIteration { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit isReverseIteration
rfornea
previously approved these changes
Nov 2, 2018
Went ahead and approved this but we should see if we can figure out what the deal is with Travis |
rfornea
approved these changes
Nov 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving the following data into S3 so that lambda could process it.
When lambda attach to the data, it would first download config data and treasure map.
And then start to upload each data/genesis hash in pairs.
When arrive to a particular index that need to skip (for inserting the treasure), Lambda will then insert it with treasure rather than the data.