Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove slf4j-simple from dependencies #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pcimcioch
Copy link

slf4j-simple is logging implementation and it shouldn't be forced as library's transient, non-optional dependency.
Adding slf4j-simple was quite disruptive, as it basically breaks applications that include this library but use other slf4j implementations (like logback).
From what I can see, it should be enough to have commons-logging in dependencies, and slf4j-simple can be used for test dependencies.

@codecov-commenter
Copy link

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #14   +/-   ##
=========================================
  Coverage     72.81%   72.81%           
  Complexity      116      116           
=========================================
  Files            20       20           
  Lines           515      515           
  Branches         38       38           
=========================================
  Hits            375      375           
  Misses          118      118           
  Partials         22       22           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 659f4ba...3a21d3a. Read the comment docs.

@skjolber
Copy link

@robertotru any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants