Remove slf4j-simple from dependencies #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slf4j-simple
is logging implementation and it shouldn't be forced as library's transient, non-optional dependency.Adding
slf4j-simple
was quite disruptive, as it basically breaks applications that include this library but use other slf4j implementations (like logback).From what I can see, it should be enough to have
commons-logging
in dependencies, andslf4j-simple
can be used for test dependencies.