Few fixes for string type input #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i recommend to introduce a new c_frontend api for this purpose, and also a new member in the class rather than changing existing prototype. This will benefit in 2 ways. 1) backward compatibility 2)not impacting any other existing functionality if this is in use for any other platform |
swaroopsarma
requested changes
Jul 18, 2024
There was a problem hiding this comment.
i recommend to introduce a new c_frontend api for this purpose, and also a new member in the class rather than changing existing prototype. This will benefit in 2 ways. 1) backward compatibility 2)not impacting any other existing functionality if this is in use for any other platform
|
I agree with adding a new API instead. This breaks backward compatibility |
ruchitg
force-pushed
the
ruchit_tdi_string_fix_v1
branch
from
891fc4b to
d4313d1
Compare
1. If the input string is mentioned as hex, take the hex representation otherwise take the input bytes and convert them to ASCII for further processing. 2. Pass the length of input bytes/string. Use this length to copy and process the string bytes. This will mitigate the risk of buffer overflows, memory corruption or information leakage and other string issues which might occur while processing string without knowning it's length. The fix will also enable to pass and have NULL char and other special chars as part of string. Signed-off-by: Ruchit Gupta <[email protected]>
ruchitg
force-pushed
the
ruchit_tdi_string_fix_v1
branch
from
d4313d1 to
3d68638
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the input string is mentioned as hex, take the hex representation otherwise take the input bytes and convert them to ASCII for further processing.
Pass the length of input bytes/string. Use this length to copy and process the string bytes. This will mitigate the risk of buffer overflows, memory corruption or information leakage and other string issues which might occur while processing string without knowning it's length. The fix will also enable to pass and have NULL char and other special chars as part of string.