Skip to content

Commit

Permalink
Fixed a few ShaderMake related issues.
Browse files Browse the repository at this point in the history
  • Loading branch information
apanteleev committed Apr 12, 2023
1 parent 7b448c6 commit 95d1a4f
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 11 deletions.
10 changes: 6 additions & 4 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,15 @@ endif()
# Point to the DXC provided through packman
set(PACKMAN_DXC "${CMAKE_CURRENT_LIST_DIR}/dxc/bin/dxc${EXE_SUFFIX}")
if (EXISTS "${PACKMAN_DXC}")
if (WIN32 AND NOT DXC_DXIL_EXECUTABLE)
set(DXC_DXIL_EXECUTABLE "${PACKMAN_DXC}" CACHE STRING "Path to DirectX Shader Compiler for DXIL output")
if (WIN32 AND NOT DXC_PATH)
set(DXC_PATH "${PACKMAN_DXC}" CACHE STRING "Path to DirectX Shader Compiler for DXIL output")
endif()
if (NOT DXC_SPIRV_EXECUTABLE)
set(DXC_SPIRV_EXECUTABLE "${PACKMAN_DXC}" CACHE STRING "Path to DirectX Shader Compiler for SPIR-V output")
if (NOT DXC_SPIRV_PATH)
set(DXC_SPIRV_PATH "${PACKMAN_DXC}" CACHE STRING "Path to DirectX Shader Compiler for SPIR-V output")
endif()
endif()
# We have our own compiler here, don't let ShaderMake search for it (and potentially fail)
set(SHADERMAKE_SEARCH_FOR_COMPILERS OFF CACHE BOOL "")

set(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin")
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_DEBUG "${CMAKE_RUNTIME_OUTPUT_DIRECTORY}")
Expand Down
4 changes: 2 additions & 2 deletions NRD.cmake
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

if (EXISTS "${CMAKE_CURRENT_LIST_DIR}/NRD/CMakeLists.txt")
set(NRD_DXC_PATH ${DXC_DXIL_EXECUTABLE})
set(NRD_DXC_SPIRV_PATH ${DXC_SPIRV_EXECUTABLE})
set(NRD_DXC_PATH ${DXC_PATH})
set(NRD_DXC_SPIRV_PATH ${DXC_SPIRV_PATH})
option(NRD_STATIC_LIBRARY "" ON)

add_subdirectory(NRD)
Expand Down
6 changes: 3 additions & 3 deletions minimal/shaders/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ set(folder "RTXDI SDK")
set(shaders_target minimal-sample-shaders)

add_custom_target(${shaders_target}
DEPENDS shaderCompiler
DEPENDS ShaderMake
SOURCES ${shaders} Shaders.cfg)

set (OUTPUT_PATH_BASE "${CMAKE_BINARY_DIR}/bin/shaders/minimal-sample")
Expand All @@ -28,7 +28,7 @@ if (DONUT_WITH_DX12)
-I ${CMAKE_CURRENT_SOURCE_DIR}/../../rtxdi-sdk/include
${USE_API_OPTION}
--relaxedInclude "../Types.h"
--compiler ${DXC_DXIL_EXECUTABLE})
--compiler ${DXC_PATH})

add_custom_command(TARGET ${shaders_target} PRE_BUILD
COMMAND ShaderMake
Expand All @@ -50,7 +50,7 @@ if (DONUT_WITH_VULKAN)
--relaxedInclude "../Types.h"
-D SPIRV
${NVRHI_DEFAULT_VK_REGISTER_OFFSETS}
--compiler ${DXC_SPIRV_EXECUTABLE})
--compiler ${DXC_SPIRV_PATH})

add_custom_command(TARGET ${shaders_target} PRE_BUILD
COMMAND ShaderMake
Expand Down
4 changes: 2 additions & 2 deletions shaders/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ set(folder "RTXDI SDK")
set(shaders_target rtxdi-sample-shaders)

add_custom_target(${shaders_target}
DEPENDS shaderCompiler
DEPENDS ShaderMake
SOURCES ${shaders} Shaders.cfg)

if(TARGET NRD)
Expand Down Expand Up @@ -72,7 +72,7 @@ if (DONUT_WITH_VULKAN)
${USE_API_OPTION}
${NVRHI_DEFAULT_VK_REGISTER_OFFSETS}
-D SPIRV
--compiler ${DXC_SPIRV_EXECUTABLE})
--compiler ${DXC_SPIRV_PATH})

add_custom_command(TARGET ${shaders_target} PRE_BUILD
COMMAND ShaderMake
Expand Down

0 comments on commit 95d1a4f

Please sign in to comment.