Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header inclusion paths #439

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Conversation

nolankramer
Copy link
Contributor

Some of the headers are under the src/ directory.

This leads to issues when including them using the redirect headers under include/QtNodes - such as DefaultNodePainter.

As an example, #include <QtNodes/DefaultNodePainter> currently contains this code:

#include "internal/DefaultNodePainter.hpp"

Which obviously points to internal/DefaultNodePainter.hpp. However, for whatever reason, that file is currently under src/, so the include path is broken.

This PR fixes all cases that are like this.

@paceholder
Copy link
Owner

Totally valid. Thanks a lot, merged

@paceholder paceholder merged commit 56a5066 into paceholder:master Oct 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants