The docblock above \Packaged\Dal\Ql\QlDao::loadOneWhere is incorrect …

…as it says that it will always return static which is not true as the default value of \Packaged\Dal\Ql\QlDaoCollection::first is null (#88) By the same token the return value of \Packaged\Dal\Ql\QlDaoCollection::first should be QlDao|null|mixed as the default value if passed can be set to anything Co-authored-by: nikolaybrankov <[email protected]>
packaged · Mar 19, 2024 · d93e0ab · d93e0ab
1 parent afcf618
commit d93e0ab
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Ql/QlDao.php b/src/Ql/QlDao.php
@@ -114,7 +114,7 @@ public function getCollection(...$params)
   /**
    * @param $params
    *
-   * @return static
+   * @return static|null
    *
    * @throws MultipleDaoException
    */

diff --git a/src/Ql/QlDaoCollection.php b/src/Ql/QlDaoCollection.php
@@ -203,7 +203,7 @@ public function delete()
    *
    * @param mixed $default
    *
-   * @return QlDao
+   * @return QlDao|null|mixed
    */
   public function first($default = null)
   {