Add tests (#9)

* Add test for filesize validator
use symfony

* if size in value

* Chang to array

* Is array check

js/validators/FileSizeValidator.js

@@ -19,7 +19,7 @@ export class FileSizeValidator extends Validator
 
   validate(value)
   {
-    if(value.hasOwnProperty('size') && value.size > (this._maxSize * 1024 * 1024))
+    if('size' in value && value.size > (this._maxSize * 1024 * 1024))
     {
       return ValidationResponse.error(['File upload cannot be more than ' + this._maxSize + 'mb in size']);
     }

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@packaged/validate",
-  "version": "3.1.3",
+  "version": "3.1.4",
   "main": "index.js",
   "repository": "[email protected]:packaged/validate",
   "author": "Tom Kay <[email protected]>",

src/Validators/FileSizeValidator.php

@@ -29,14 +29,14 @@ public static function deserialize($configuration): SerializableValidator
   public function serialize(): array
   {
     return [
-      'maxSize' => $this->_maxSize,
+      'maxSize' => $this->getMaxSize(),
     ];
   }
 
   protected function _doValidate($value): Generator
   {
     // Validation
-    if(array_key_exists('size', $value) && $value['size'] < ($this->_maxSize * 1024 * 1024))
+    if(is_array($value) && array_key_exists('size', $value) && $value['size'] > ($this->_maxSize * 1024 * 1024))
     {
       yield $this->_makeError("File upload cannot be more than " . $this->_maxSize . "mb in size");
     }

tests/FileSizeValidatorTest.php

@@ -0,0 +1,19 @@
+<?php
+namespace Packaged\Validate\Tests;
+
+use Packaged\Validate\Validators\FileSizeValidator;
+use PHPUnit\Framework\TestCase;
+
+class FileSizeValidatorTest extends TestCase
+{
+  public function testNumberValidation()
+  {
+    $upload = ['size' => 1159144];
+    $validator = new FileSizeValidator(3);
+
+    $largeUpload = ['size' => 5123224];
+
+    $this->assertTrue($validator->isValid($upload));
+    $this->assertFalse($validator->isValid($largeUpload));
+  }
+}