fix warnings

packbackbooks · Feb 13, 2024 · 9ed77d0 · 9ed77d0
1 parent 724480c
commit 9ed77d0
Show file tree

Hide file tree

Showing 14 changed files with 40 additions and 2 deletions.
diff --git a/tests/Certification/Lti13CertificationTest.php b/tests/Certification/Lti13CertificationTest.php
@@ -141,6 +141,9 @@ class Lti13CertificationTest extends TestCase
     private $issuer;
     private $key;
     private array $payload;
+    private $cache;
+    private $cookie;
+    private $serviceConnector;
 
     public function setUp(): void
     {

diff --git a/tests/DeepLinkResources/IconTest.php b/tests/DeepLinkResources/IconTest.php
@@ -7,6 +7,8 @@
 
 class IconTest extends TestCase
 {
+    private $imageUrl;
+    private $icon;
     public function setUp(): void
     {
         $this->imageUrl = 'https://example.com/image.png';

diff --git a/tests/Lti1p1KeyTest.php b/tests/Lti1p1KeyTest.php
@@ -6,6 +6,7 @@
 
 class Lti1p1KeyTest extends TestCase
 {
+    private $key;
     public function setUp(): void
     {
         $this->key = new Lti1p1Key();

diff --git a/tests/LtiAssignmentsGradesServiceTest.php b/tests/LtiAssignmentsGradesServiceTest.php
@@ -13,6 +13,8 @@
 
 class LtiAssignmentsGradesServiceTest extends TestCase
 {
+    private $connector;
+    private $registration;
     public function setUp(): void
     {
         $this->connector = Mockery::mock(ILtiServiceConnector::class);
@@ -452,7 +454,7 @@ public function testItGetsLineItems()
         $this->assertEquals($response, $result);
     }
 
-    public function testItGetsALineItems()
+    public function testItGetsALineItem()
     {
         $serviceData = [
             'scope' => [LtiConstants::AGS_SCOPE_LINEITEM],
@@ -475,5 +477,7 @@ public function testItGetsALineItems()
             ->once()->andReturn($response);
 
         $result = $service->getLineItems();
+
+        $this->assertEquals($expected, $result);
     }
 }
diff --git a/tests/LtiCourseGroupsServiceTest.php b/tests/LtiCourseGroupsServiceTest.php
@@ -9,6 +9,8 @@
 
 class LtiCourseGroupsServiceTest extends TestCase
 {
+    private $connector;
+    private $registration;
     public function setUp(): void
     {
         $this->connector = Mockery::mock(ILtiServiceConnector::class);

diff --git a/tests/LtiDeploymentTest.php b/tests/LtiDeploymentTest.php
@@ -7,7 +7,7 @@
 class LtiDeploymentTest extends TestCase
 {
     private $id = 'a deployment';
-
+    private $deployment;
     public function setUp(): void
     {
         $this->deployment = new LtiDeployment($this->id);

diff --git a/tests/LtiGradeSubmissionReviewTest.php b/tests/LtiGradeSubmissionReviewTest.php
@@ -6,6 +6,8 @@
 
 class LtiGradeSubmissionReviewTest extends TestCase
 {
+    private $gradeReview;
+
     public function setUp(): void
     {
         $this->gradeReview = new LtiGradeSubmissionReview();

diff --git a/tests/LtiGradeTest.php b/tests/LtiGradeTest.php
@@ -6,6 +6,7 @@
 
 class LtiGradeTest extends TestCase
 {
+    private $grade;
     public function setUp(): void
     {
         $this->grade = new LtiGrade();

diff --git a/tests/LtiMessageLaunchTest.php b/tests/LtiMessageLaunchTest.php
@@ -40,6 +40,8 @@ class LtiMessageLaunchTest extends TestCase
     private array $issuer;
     private array $key;
     private array $payload;
+    private $migrationDatabase;
+    private $deployment;
 
     public function setUp(): void
     {

diff --git a/tests/LtiNamesRolesProvisioningServiceTest.php b/tests/LtiNamesRolesProvisioningServiceTest.php
@@ -9,6 +9,8 @@
 
 class LtiNamesRolesProvisioningServiceTest extends TestCase
 {
+    private $connector;
+    private $registration;
     public function setUp(): void
     {
         $this->connector = Mockery::mock(ILtiServiceConnector::class);

diff --git a/tests/LtiOidcLoginTest.php b/tests/LtiOidcLoginTest.php
@@ -13,6 +13,10 @@
 
 class LtiOidcLoginTest extends TestCase
 {
+    private $cache;
+    private $cookie;
+    private $database;
+    private $oidcLogin;
     public function setUp(): void
     {
         $this->cache = Mockery::mock(ICache::class);

diff --git a/tests/LtiRegistrationTest.php b/tests/LtiRegistrationTest.php
@@ -6,6 +6,8 @@
 
 class LtiRegistrationTest extends TestCase
 {
+    private $registration;
+
     public function setUp(): void
     {
         $this->registration = new LtiRegistration();

diff --git a/tests/LtiServiceConnectorTest.php b/tests/LtiServiceConnectorTest.php
@@ -40,6 +40,18 @@ class LtiServiceConnectorTest extends TestCase
      * @var LtiServiceConnector
      */
     private $connector;
+    private $responseStatus;
+    private $responseBody;
+    private $responseHeaders;
+    private $request;
+    private $requestPayload;
+    private $requestHeaders;
+    private $body;
+    private $url;
+    private $method;
+    private $token;
+    private $scopes;
+    private $streamInterface;
 
     public function setUp(): void
     {

diff --git a/tests/ServiceRequestTest.php b/tests/ServiceRequestTest.php
@@ -9,6 +9,7 @@ class ServiceRequestTest extends TestCase
     private $method = ServiceRequest::METHOD_GET;
     private $url = 'https://example.com';
     private $type = ServiceRequest::TYPE_AUTH;
+    private $request;
 
     public function setUp(): void
     {