Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap to pint for linting #122

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Swap to pint for linting #122

merged 2 commits into from
Dec 19, 2023

Conversation

dbhynds
Copy link
Member

@dbhynds dbhynds commented Dec 15, 2023 •
edited
Loading

Summary of Changes

Change our linter to pint, since that's the Laravel one and the one we use on the platform.

Testing

  • I have added automated tests for my changes
  • I ran composer test before opening this PR
  • I ran composer lint-fix before opening this PR

@dbhynds dbhynds requested a review from cophaso December 15, 2023 22:54
cophaso
cophaso approved these changes Dec 18, 2023
View reviewed changes
Copy link

@cophaso cophaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to run composer lint-fix without any issues.

Base automatically changed from v6-phpstan to v6.0-beta December 19, 2023 19:48
@dbhynds dbhynds merged commit 80686bd into v6.0-beta Dec 19, 2023
3 checks passed
@dbhynds dbhynds deleted the pint branch December 19, 2023 19:48
@dbhynds dbhynds mentioned this pull request Dec 21, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cophaso cophaso cophaso approved these changes

Assignees

@cophaso cophaso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbhynds @cophaso