Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: using the gem under Ruby 3.4 prints a warning about future incompatibility. #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kewlar
Copy link
Contributor

@kewlar kewlar commented Dec 18, 2024

Starting from Ruby 3.5.0, benchmark gem will no longer be part of the default gems. In order to prepare for that, Ruby 3.4.0-rc1 prints a warning:

$ aoc
~/.rbenv/versions/3.4.0-rc1/lib/ruby/gems/3.4.0+1/gems/aoc_rb-0.2.10/lib/aoc_rb/app.rb:10: warning: benchmark was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add benchmark to your Gemfile or gemspec to silence this warning.
...

(interestingly, the warning seems slightly misleading, as the benchmark gem is actually required and used in lib/aoc_rb/puzzle_source.rb)

This PR adds benchmark as an explicit dependency, and thus gets rid of the warning under Ruby 3.4, and prepares the gem for compatibility with Ruby 3.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant